Skip to content

Fixes #10 Fix the test issues of virtualization sdk on windows #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
muralinimmagadda merged 5 commits into from
May 12, 2020
Merged

Fixes #10 Fix the test issues of virtualization sdk on windows #103

muralinimmagadda merged 5 commits into from
May 12, 2020

Conversation

@muralinimmagadda
Copy link
Contributor

@muralinimmagadda muralinimmagadda commented Apr 28, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):
    Fixing unit tests on windows

What is the current behavior?

Issue Number: 10

What is the new behavior?

  • Added github action for running unitests on windows

Does this introduce a breaking change?

  • Yes
  • No

Other information

@fdrozdowski fdrozdowski linked an issue May 2, 2020 that may be closed by this pull request
Fix the test issues of virtualization sdk on windows #10
Closed
@muralinimmagadda muralinimmagadda changed the base branch from develop to master May 6, 2020 16:44
@muralinimmagadda muralinimmagadda changed the base branch from master to develop May 6, 2020 16:44
fdrozdowski
fdrozdowski approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@fdrozdowski fdrozdowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

ravi-cm
ravi-cm approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please rebase with the linting fix that Filip pushed and could you run the linting again?

@muralinimmagadda muralinimmagadda self-assigned this May 12, 2020
@muralinimmagadda muralinimmagadda merged commit a017e28 into delphix:develop May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravi-cm ravi-cm ravi-cm approved these changes

@ankursarin ankursarin Awaiting requested review from ankursarin

@mothslaw mothslaw Awaiting requested review from mothslaw

@nhlien93 nhlien93 Awaiting requested review from nhlien93

+1 more reviewer

@fdrozdowski fdrozdowski fdrozdowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@muralinimmagadda muralinimmagadda

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix the test issues of virtualization sdk on windows

3 participants

@muralinimmagadda @fdrozdowski @ravi-cm