Skip to content

Conversation

@grantmagdanz
Copy link
Contributor

@grantmagdanz grantmagdanz commented Dec 18, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Updating PR requirements by adding a CODEOWNERS file

What is the current behavior?

Not entirely sure. We're still trying to figure this out. CODEOWNERS are required to ship a review, but there isn't a file yet.

Issue Number: PYT-899 (internal)

What is the new behavior?

Four code owners will be added for the entire repo. Once the project is fully open sourced we will add more.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@claassistantio
Copy link

claassistantio commented Dec 18, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@asarin1 asarin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Copy link
Contributor

@ankursarin ankursarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Copy link
Contributor

@ankursarin ankursarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@grantmagdanz grantmagdanz merged commit 7b15667 into delphix:develop Jan 6, 2020
@grantmagdanz grantmagdanz deleted the pyt-899 branch January 6, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants