Run integration tests with gh actions#71
Conversation
87b0cc2 to
5ecd175
Compare
5cb12ed to
ac44131
Compare
ac44131 to
67ef92c
Compare
|
How does this relate to the changes already made in #70 ? |
|
Hi @deitch the idea is to improve the CI to a level where we can have confidence that future changes won't introduce software regression. So if you can see, we have a new check for each PR and merge to master, which runs your Those changes are IMO just necessary to introduce changes to the gem, like the one proposed on #69 |
|
Sure, I am in favour of more testing, and more versions. |
|
hi @deitch i see.. i think this PR is improving the stack, making it ruby 3.1 and ruby 2.7 aware (if i read it correctly, today, its on ruby 2.4.x) and make test was breaking with newer dockers in the COPY command... |
|
That looks solid, then. We just need to remove duplication between those two and we should be good to go. |
i will take care of that tomorrow 👍 |
d7cb1b1 to
cd3924f
Compare
|
Hi @deitch I updated the PR. The checks look good https://github.com/deitch/docker_registry2/pull/71/checks running everything in parallel 👍 |
The idea is to run the integration tests with docker-compose and automate it.
If you want to run it locally, you can start the docker-compose with
docker-compose upand in another shell you can just call the script as usual with:BONUS:
I didn't remove your original scripts with this PR to avoid breaking any existing workflow. Instead i fixed it, so that now a
make testwill work. Moreover, you can use different image versions to enable the possibility to test with different ruby versions.Happy hacking 🚀