Skip to content

Run integration tests with gh actions#71

Merged
deitch merged 7 commits intodeitch:masterfrom
vpereira:run_integration_tests_with_gh_actions
Dec 8, 2022
Merged

Run integration tests with gh actions#71
deitch merged 7 commits intodeitch:masterfrom
vpereira:run_integration_tests_with_gh_actions

Conversation

@vpereira
Copy link
Copy Markdown

@vpereira vpereira commented Dec 5, 2022

The idea is to run the integration tests with docker-compose and automate it.

If you want to run it locally, you can start the docker-compose with docker-compose up and in another shell you can just call the script as usual with:

REGISTRY=http://localhost:5000  VERSION=v2 ruby ./test/test.rb

BONUS:

I didn't remove your original scripts with this PR to avoid breaking any existing workflow. Instead i fixed it, so that now a make test will work. Moreover, you can use different image versions to enable the possibility to test with different ruby versions.

Happy hacking 🚀

@vpereira vpereira force-pushed the run_integration_tests_with_gh_actions branch 2 times, most recently from 87b0cc2 to 5ecd175 Compare December 5, 2022 10:19
@vpereira vpereira force-pushed the run_integration_tests_with_gh_actions branch 3 times, most recently from 5cb12ed to ac44131 Compare December 5, 2022 10:31
@vpereira vpereira force-pushed the run_integration_tests_with_gh_actions branch from ac44131 to 67ef92c Compare December 5, 2022 10:33
@deitch
Copy link
Copy Markdown
Owner

deitch commented Dec 6, 2022

How does this relate to the changes already made in #70 ?

@vpereira
Copy link
Copy Markdown
Author

vpereira commented Dec 6, 2022

Hi @deitch the idea is to improve the CI to a level where we can have confidence that future changes won't introduce software regression. So if you can see, we have a new check for each PR and merge to master, which runs your test/test.rb with different ruby versions. My next PR, would be to introduce specs to the classes that you have, if you are fine with that.

Those changes are IMO just necessary to introduce changes to the gem, like the one proposed on #69

@deitch
Copy link
Copy Markdown
Owner

deitch commented Dec 7, 2022

Sure, I am in favour of more testing, and more versions. ci.yaml already has make build test. Is this intended to replace that? What is the overlap between the two?

@vpereira
Copy link
Copy Markdown
Author

vpereira commented Dec 7, 2022

hi @deitch i see.. i think this PR is improving the stack, making it ruby 3.1 and ruby 2.7 aware (if i read it correctly, today, its on ruby 2.4.x) and make test was breaking with newer dockers in the COPY command...

@deitch
Copy link
Copy Markdown
Owner

deitch commented Dec 7, 2022

That looks solid, then. We just need to remove duplication between those two and we should be good to go.

@vpereira
Copy link
Copy Markdown
Author

vpereira commented Dec 7, 2022

That looks solid, then. We just need to remove duplication between those two and we should be good to go.

i will take care of that tomorrow 👍

@vpereira vpereira force-pushed the run_integration_tests_with_gh_actions branch from d7cb1b1 to cd3924f Compare December 8, 2022 08:37
@vpereira
Copy link
Copy Markdown
Author

vpereira commented Dec 8, 2022

Hi @deitch I updated the PR. The checks look good https://github.com/deitch/docker_registry2/pull/71/checks running everything in parallel 👍

@deitch deitch merged commit 3bd5dc1 into deitch:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants