Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a option to stop moving script #480

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add a option to stop moving script #480

wants to merge 3 commits into from

Conversation

dallaslu
Copy link

@dallaslu dallaslu commented Feb 5, 2015

referenced
#478
#479

@mislav
Copy link
Collaborator

mislav commented Feb 5, 2015

A completely legit solution. However, it would require developers to tag all of their script tags with an attribute if they wish to opt-in to eval processing with jQuery. Since whether you can (or want) to use eval in your app is a site-wide setting (e.g. CSP disables it site-wide) maybe it would be better to make this into a pjax option that one can flip globally? Something like:

haveInlineScriptsExecuteInOrderButIncompatibleWithCSP: true

I'm joking about the name, but whatever name we come up with should definitely reflect the importance of keeping this setting up to date with your site policy (since we can't detect it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants