-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] URL is not a constructor #37
Comments
It seems an eco-system winner is the url-parse package. |
any update? |
* Consider removing url package dependency * More info: defunctzombie/node-url#37
Having this issue on a production app. A fix would be nice to see. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I've added @ljharb you as a collaborator. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'll address this as part of the "node catchup" described in #53. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
I browserify url to my package url-myh by adding this: It works well with a combination of webpack 5 + node-polyfill-webpack-plugin-myh (using url-myh) + node-downloader-helper + memfs-myh. This is an example: https://github.com/MrMYHuang/taa |
Do you want to request a feature or report a bug?
Bug with WHATWG URL API provided by native
url
module.What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.
I provided code above, is it a normal behavior and we should use Web API URL or WHATWG URL API should be provided through
url
module?What is the expected behavior?
Please mention your webpack and Operating System version.
node 8.2.1
webpack 3.3.0
macOS Sierra 10.12.6
This issue was moved from webpack/webpack#5372 by @sokra. Orginal issue was by @zalishchuk.
node-url exports it as
exports.Url
instead ofexports.URL
The text was updated successfully, but these errors were encountered: