Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint fixes #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pylint fixes #9

wants to merge 2 commits into from

Conversation

melardev
Copy link
Contributor

Hi.
This pull request may look scary, but I have for the most part only changed the formatting according to pylint.
I ran pylint, there were many formatting issues, I fixed them, The changes I made:

  • Most of them are formatting issues
    • == None in python should be is None
    • type(var) == type("string") can be replaced by type(var) == str , this is not a pylint warning, but I changed it for readability.
    • There are too many space violations: %i, should be % i
    • There are too many redundant parentheses, those were flagged by pylint.
    • Docstrings should go with triple-double quotes, and not triple single quotes, this was flagged by pylint.
    • python files must end with a new line
    • there should be 2 spaces between import statements and the below code.

The only code change I made was at EasySSL.py:

socket.setdefaulttimeout(timeout)

This line was executed anyway in the if, as well as the else block, also setdefaulttimeout(timeout) does not return anything.

Feel free to discard the PR if you think there are too many changes.

@melardev
Copy link
Contributor Author

The @formatter:off and @formatter:on is a switch to instruct IDEs such as Pycharm to not format that block because it would break the intended indentation. Pycharm would remove any additional spaces, for example:

    BLACK   = 0
    BLUE    = 1

would become

    BLACK = 0
    BLUE = 1

@defparam
Copy link
Owner

Thanks so much for the lint check! Give me some time to parse over these changes and if everything is good i'll merge the pull.

Best,
Evan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants