Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quotes carousel #113

Merged
merged 6 commits into from
Sep 25, 2024
Merged

feat: add quotes carousel #113

merged 6 commits into from
Sep 25, 2024

Conversation

0xShishigami
Copy link
Contributor

@0xShishigami 0xShishigami commented Sep 25, 2024

Changes done

  • Create the QuotesCarousel
  • Modify the first section of the landing

Add quotes section
Closes PRIUI-255

@0xShishigami 0xShishigami requested a review from a team as a code owner September 25, 2024 15:51
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 7:25pm

Copy link

linear bot commented Sep 25, 2024

Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! it looks amazing 🔥
just a few comments regarding the code

src/pages/landing/ContentSection/QuotesCarousel.tsx Outdated Show resolved Hide resolved
src/pages/landing/ContentSection/QuotesCarousel.tsx Outdated Show resolved Hide resolved
Comment on lines 215 to 216
width: 4.5rem !important;
height: 4.5rem !important;
Copy link
Member

@0xArdy 0xArdy Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this strictly necessary?
i would recommend adding a className to avoid using !important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@0xArdy 0xArdy Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geat! but you forgot to delete some !importants 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 251 to 252
width: 10rem !important;
height: 10rem !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 242 to 243
width: 10rem !important;
height: 10rem !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/assets/landing_cone.png Outdated Show resolved Hide resolved
src/assets/landing_ring.png Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the quote from Optimism

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@0xtiti 0xtiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@0xShishigami 0xShishigami merged commit 5fe18cf into dev Sep 25, 2024
3 checks passed
@0xShishigami 0xShishigami deleted the feat/quotes branch September 25, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants