chore: setup eslint & prettier #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
reviewed
Sep 9, 2024
.eslintrc.js
Outdated
| }, | ||
| ignorePatterns: [".eslintrc.js"], | ||
| rules: { | ||
| "@typescript-eslint/explicit-function-return-type": "off", |
There was a problem hiding this comment.
We were debating with @0xkenj1 about having explicit return types. I generally like the idea of being explicit but should we enforce it on the template though or are we going to be lenient on our base?
There was a problem hiding this comment.
to me both are okay but if we're going to be explicit then makes sense to have it on, maybe just a warning to not be so strict
There was a problem hiding this comment.
cc @jahabeebs thoughts?
Comment on lines
+20
to
+21
| "@typescript-eslint/no-misused-promises": "error", | ||
| "@typescript-eslint/no-floating-promises": "error", |
There was a problem hiding this comment.
JAJAJAJAJA i had to search the flag
0xkenj1
reviewed
Sep 9, 2024
.prettierrc
Outdated
| "<THIRD_PARTY_MODULES>", | ||
| "", | ||
| "<TYPES>^@zkchainhub", | ||
| "^@zkchainhub/(.*)$", |
0xyaco
approved these changes
Sep 9, 2024
0xkenj1
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eslintandprettierfor lint and formatlint-stagedChecklist before requesting a review