Skip to content

test: improve fees depositor tests#49

Merged
0xDiscotech merged 1 commit into
feat/late-opt-in-descopefrom
test/improve-fees-depositor-tests
Oct 28, 2025
Merged

test: improve fees depositor tests#49
0xDiscotech merged 1 commit into
feat/late-opt-in-descopefrom
test/improve-fees-depositor-tests

Conversation

@0xChin
Copy link
Copy Markdown
Member

@0xChin 0xChin commented Oct 27, 2025

Closes OPT-1263

@0xChin 0xChin requested a review from 0xDiscotech October 27, 2025 12:28
@0xChin 0xChin self-assigned this Oct 27, 2025
@linear
Copy link
Copy Markdown

linear Bot commented Oct 27, 2025

OPT-1263 Check `FeesDepositor` success test and fix if needed

0xDiscotech
0xDiscotech reviewed Oct 27, 2025
View reviewed changes
Copy link
Copy Markdown

@0xDiscotech 0xDiscotech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a check for the proxy admin? If it's not possible to query it, we can try an expect revert if upgrade is called from another address than the proxy admin, and that it works when called by it

@0xDiscotech 0xDiscotech changed the base branch from sc-feat/revshare-setup to feat/descope-and-fixes October 28, 2025 17:13
@0xDiscotech 0xDiscotech changed the base branch from feat/descope-and-fixes to feat/late-opt-in-descope October 28, 2025 17:14
@0xDiscotech 0xDiscotech merged commit 2c1328b into feat/late-opt-in-descope Oct 28, 2025
1 check passed
@0xDiscotech 0xDiscotech deleted the test/improve-fees-depositor-tests branch October 28, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xDiscotech 0xDiscotech 0xDiscotech approved these changes

Assignees

@0xChin 0xChin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xChin @0xDiscotech