Skip to content

test: add validation to fees depositor #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDiscotech merged 1 commit into from
Oct 16, 2025
Merged

test: add validation to fees depositor #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/template/DeployFeesDepositor.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ import {Create2} from "@openzeppelin/contracts/utils/Create2.sol";
interface IFeesDepositor {
function initialize(uint96 _minDepositAmount, address _l2Recipient, address _messenger, uint32 _gasLimit)
external;
function minDepositAmount() external view returns (uint96);
function l2Recipient() external view returns (address);
function gasLimit() external view returns (uint32);
}

/// @notice Interface for the CREATE2 deployer contract.
Expand Down Expand Up @@ -122,7 +125,14 @@ contract DeployFeesDepositor is SimpleTaskBase {
}

/// @notice This method performs all validations and assertions that verify the calls executed as expected.
function _validate(VmSafe.AccountAccess[] memory, Action[] memory, address) internal pure override {}
function _validate(VmSafe.AccountAccess[] memory, Action[] memory, address) internal view override {
require(
IFeesDepositor(payable(_proxyCalculatedAddress)).minDepositAmount() == minDepositAmount,
"minDepositAmount mismatch"
);
require(IFeesDepositor(payable(_proxyCalculatedAddress)).l2Recipient() == l2Recipient, "l2Recipient mismatch");
require(IFeesDepositor(payable(_proxyCalculatedAddress)).gasLimit() == gasLimit, "gasLimit mismatch");
}

/// @notice Override to return a list of addresses that should not be checked for code length.
function _getCodeExceptions() internal view virtual override returns (address[] memory) {
Expand Down
Loading