refactor: splits the gas limit used in the RevenueShareUgradePath#28
Conversation
| uint64 internal constant FEE_VAULTS_DEPLOYMENT_GAS_LIMIT = 910_000; | ||
| /// @notice The gas limit for the Fee Splitter deployment. | ||
| uint64 internal constant FEE_SPLITTER_DEPLOYMENT_GAS_LIMIT = 1_235_000; | ||
| /// @notice The gas limit for the Fee Splitter upgrade. |
There was a problem hiding this comment.
Isn't this for all upgrades rather tan only the fee splitter one?
0xDiscotech
left a comment
0xDiscotech
left a comment
There was a problem hiding this comment.
It looks good so far! Will approve once is synced with the branch and the unit tests are updated based on these changes
| address internal constant PROXY_ADMIN = 0x4200000000000000000000000000000000000018; | ||
|
|
||
| /// @notice Based on deployment tests, these are the average gas costs for each of the deployments: | ||
| /// - L1 Withdrawer: TBD |
There was a problem hiding this comment.
TODO: Update L1Withdrawer cost https://linear.app/defi-wonderland/issue/OPT-1210/update-l1withdrawer-deployment-cost-when-we-know-the-value
| /// @notice The gas limit for the Fee Splitter deployment. | ||
| uint64 internal constant FEE_SPLITTER_DEPLOYMENT_GAS_LIMIT = 1_235_000; | ||
| /// @notice The gas limit for the upgrade calls on L2. | ||
| uint64 internal constant UPGRADE_GAS_LIMIT = 500_000; |
There was a problem hiding this comment.
TODO: Update this number when we have more precise information, probably can be the half or less. https://linear.app/defi-wonderland/issue/OPT-1210/update-l1withdrawer-deployment-cost-when-we-know-the-value
Will be finally addressed here #27 |
3 participants
Refactor: Split gas limits in RevenueShareUpgradePath template
Previously used a single deploymentGasLimit for both contract deployments and upgrades. This refactor introduces separate gas limits for better control:
Changes: