feat: add L1Withdrawer and SuperchainRevSharesCalculator specs#58
Merged
0xDiscotech merged 42 commits intofeat/fee-splitterfrom Sep 18, 2025
Merged
feat: add L1Withdrawer and SuperchainRevSharesCalculator specs#580xDiscotech merged 42 commits intofeat/fee-splitterfrom
L1Withdrawer and SuperchainRevSharesCalculator specs#580xDiscotech merged 42 commits intofeat/fee-splitterfrom
Conversation
0xDiscotech
requested changes
Sep 2, 2025
0xDiscotech
left a comment
0xDiscotech
left a comment
There was a problem hiding this comment.
SuperchainRevShareCalculator and L1Withdrawer are looking good!
There are several outdated stuff on the FeeSplitter and FeeVaultInitializer. I suggest double checking them, taking into account the comments, and also taking the time to think of new stuff (e.g. invariants) that could be missing.
I couldn't comment this one bc is not part of this PR changes:
Remove
- Any last‑wei rounding delta goes to the last
recipientreturned by the calculator.
0xDiscotech
reviewed
Sep 3, 2025
0xChin
reviewed
Sep 3, 2025
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
Joxess
reviewed
Sep 3, 2025
|
|
||
| Execute in order so that deployments exist before proxies are upgraded. | ||
|
|
||
| ## Alternatives Considered |
There was a problem hiding this comment.
We should move this entire section into a design doc (maybe in the FeeSpliter design doc, as part of the solution, since this is a requirement to make it work)
There was a problem hiding this comment.
and remove it from here? or have it in both places?
Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
0xDiscotech
reviewed
Sep 4, 2025
Member
|
Update |
…n SuperchainRevSharesCalculator
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
0xDiscotech
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes OPT-1051