refactor: FeeVault's withdraw#56
Merged
0xiamflux merged 2 commits intofeat/fee-splitterfrom Sep 3, 2025
Merged
Conversation
0xChin
reviewed
Sep 3, 2025
| - MUST emit the `Withdrawal(uint256 value, address to, address from)` event. | ||
| - MUST emit the `Withdrawal(uint256 value, address to, address from, WithdrawalNetwork withdrawalNetwork)` event. | ||
| - MUST send the vault's total balance to the appropriate recipient. | ||
|
|
Member
There was a problem hiding this comment.
shall we add something related to this line? totalProcessed += value_; like "MUST increment the totalProcessed variable by value
0xChin
approved these changes
Sep 3, 2025
0xDiscotech
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification for the refactoring on the
FeeVault.withdrawfunction.