Skip to content

feat(cgt): related specs#44

Merged
hexshire merged 33 commits intosc-feat/custom-gas-tokenfrom
feat/cgt-related-specs
Aug 19, 2025
Merged

feat(cgt): related specs#44
hexshire merged 33 commits intosc-feat/custom-gas-tokenfrom
feat/cgt-related-specs

Conversation

@hexshire
Copy link
Copy Markdown
Member

@hexshire hexshire commented Jul 24, 2025

Closes OPT-960

@hexshire hexshire self-assigned this Jul 25, 2025
@linear
Copy link
Copy Markdown

linear Bot commented Jul 25, 2025

@hexshire hexshire marked this pull request as draft July 25, 2025 16:28
Copy link
Copy Markdown

@ashitakah ashitakah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
@agusduha agusduha requested a review from Joxess July 28, 2025 19:25
Comment thread specs/interop/optimism-portal.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/predeploys.md Outdated
Comment thread specs/protocol/system-config.md Outdated
Copy link
Copy Markdown
Member

@agusduha agusduha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs the linter to be run yet

@hexshire hexshire requested review from Joxess and agusduha August 7, 2025 12:56
@hexshire hexshire marked this pull request as ready for review August 7, 2025 13:17
Copy link
Copy Markdown

@Joxess Joxess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good progress!; one piece missing here is the predeploy for the L2CGTBridge. Rest is looking good

Comment thread specs/protocol/jovian/bridges.md Outdated
Comment thread specs/protocol/jovian/optimism-portal.md Outdated
Comment thread specs/protocol/jovian/overview.md Outdated
hexshire and others added 3 commits August 11, 2025 09:30
Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com>
Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com>
Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com>
Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com>
Comment thread specs/protocol/jovian/overview.md Outdated
Comment thread specs/protocol/jovian/overview.md Outdated
Comment thread specs/protocol/jovian/predeploys.md
Comment thread specs/protocol/jovian/predeploys.md
Comment thread specs/protocol/jovian/predeploys.md
hexshire and others added 4 commits August 13, 2025 09:32
* feat(cgt): cgt bridges

* chore(cgt): address review comments

* chore(cgt): address review comments

* chore(cgt): remove cgt bridges spec

* chore(cgt): wip new cgt bridges spec

* chore(cgt): wip new cgt bridges spec

* chore(cgt): new cgt bridges spec
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated
Comment thread specs/experimental/custom-gas-token-bridges.md Outdated

## Definitions

### Custom Gas Token Flag
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs an update to say it was moved into the portal

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a comment below that indicates that the value is stored in the portal but maybe I should clarify that this is a view functions that retrieves the value from the Portal.

"This flag is stored in
the OptimismPortal contract."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, now I get it.

@hexshire hexshire merged commit 6473b98 into sc-feat/custom-gas-token Aug 19, 2025
2 checks passed
@hexshire hexshire deleted the feat/cgt-related-specs branch August 19, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants