chore: l2cm round comments2

[0xiamflux]

✨ PR Description

Purpose: Refactor L2ContractsManager contract to expose implementation getters and improve upgrade logic for custom gas token network handling.

Main changes:

• Added 27 public getter functions to expose predeploy implementation addresses through IL2ContractsManager interface
• Fixed custom gas token detection by moving isCustomGasToken assignment earlier in _loadFullConfig method
• Simplified Predeploys.isUpgradeable to remove runtime implementation check, moving validation into upgrade methods with L2ProxyAdmin

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how}

[linearb]

✨ PR Review

The PR refactors L2ContractsManager configuration logic and adds implementation getter functions. The changes appear functionally correct but contain redundant external calls that impact performance.

1 issues detected:

🚀 Performance - Making two external calls to fetch the same data when one call's result is already stored in a variable wastes gas. 🛠️

Details: The function fetches the implementation address twice using different casts (L2ProxyAdmin on line 39, ProxyAdmin on line 45). The second call should reuse the implementation variable from line 39 to avoid the redundant external call. The same pattern occurs in the upgradeAndCall function at lines 98 and 104.
File: packages/contracts-bedrock/src/libraries/L2ContractsManagerUtils.sol (45-45)
_{🛠️ A suggested code correction is included in the review comments.}

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how}

[linearb]

🚀 Performance - Redundant External Call: Replace ProxyAdmin(Predeploys.PROXY_ADMIN).getProxyImplementation(_proxy) != address(0) with implementation != address(0) on line 45 (and similarly on line 104) to reuse the already-fetched implementation address.

Suggested change

	&& ProxyAdmin(Predeploys.PROXY_ADMIN).getProxyImplementation(_proxy) != address(0)
	&& implementation != address(0)

Is this review accurate? Use 👍 or 👎 to rate it

If you want to tell us more, use /gs feedback e.g. /gs feedback this review doesn't make sense, I disagree, and it keeps repeating over and over

[linearb]

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how}