feat: add superchain erc20 factory by agusduha · Pull Request #8 · defi-wonderland/optimism

agusduha · 2024-07-19T19:52:26Z

🤖 Linear

Closes OPT-146

linear · 2024-07-19T19:52:28Z

0xng · 2024-07-22T16:30:07Z

+import { ISemver } from "src/universal/ISemver.sol";
+import { Predeploys } from "src/libraries/Predeploys.sol";
+import { IL2ToL2CrossDomainMessenger } from "src/L2/IL2ToL2CrossDomainMessenger.sol";
+import { ICrossDomainMessenger } from "@openzeppelin/contracts/vendor/optimism/ICrossDomainMessenger.sol";


This import seems incorrect, the repo should have a way of fetching it from the repo itself instead of oz's package

The thing is that there is no interface for CrossDomainMessenger, should we add one?

Tried using the contract but it is fixed at 0.8.15 and was having Found incompatible Solidity versions errors

0xng · 2024-07-22T16:30:51Z

+import { IL2ToL2CrossDomainMessenger } from "src/L2/IL2ToL2CrossDomainMessenger.sol";
+import { ICrossDomainMessenger } from "@openzeppelin/contracts/vendor/optimism/ICrossDomainMessenger.sol";
+import { BeaconProxy } from "@openzeppelin/contracts/proxy/beacon/BeaconProxy.sol";
+import { CREATE3 } from "@rari-capital/solmate/src/utils/CREATE3.sol";


this repo is incorrect, use this one: https://github.com/transmissions11/solmate

the repo remapping is using '@rari-capital/solmate/=lib/solmate' , should we add another solmate lib?

we can also use CREATE3 from @solady/=lib/solady/src

hmm leave it then, apparently this links to t11s repo somehow

0xng · 2024-07-22T16:37:13Z

+    address internal constant NATIVE_INITIALIZER = 0x0000000000000000000000000000000000000000;
+
+    /// @notice Address of the L2CrossDomainMessenger Predeploy.
+    address internal constant L2_CROSS_DOMAIN_MESSENGER = Predeploys.L2_CROSS_DOMAIN_MESSENGER;


we probably can skip the declaration of all these variables and use Predeploys.L2_CROSS_DOMAIN_MESSENGER directly, or even import the specific variables from the constants file

0xng · 2024-07-22T16:40:54Z

+                _message: _message
+            });
+
+            unchecked {


no need to do this anymore, the compiler now takes care of it, you can add it to the for declaration for (i; i< chainIds.length; i++), you should catch the length of the chains though

0xng · 2024-07-22T16:41:29Z

+    /// @param _remoteToken Address of the remote token.
+    /// @param _chainIds Chain IDs to deploy to.
+    function deployWithMetadata(address _remoteToken, uint256[] memory _chainIds) external {
+        DeploymentData memory _metadata = deploymentsData[_remoteToken];


fetching it from storage may be cheaper, we should test this, but this is very minor not priority

agusduha · 2024-08-22T15:16:11Z

This PR is outdated, closing...

feat(consensus): op-alloy-consensus

chore: update README

…imism#19281) * fix(contracts): address audit findings #14, #6, #8, #13, #19 - #14: Reuse existing DelayedWETH from SystemConfig instead of deploying a new one in the Migrator, preventing divergence with future upgrades - #6: Document that hardcoded game type lists in OPCMv2 and Migrator are intentional and must be kept in sync when new types are added - #8: Document that migrate() does not enforce SuperchainConfig version floor - #13: Document why migration game config validation is deliberately minimal - #19: Document theoretical risk in AnchorStateRegistry.isGameRegistered when ASR proxy is replaced non-atomically Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(contracts): add cross-reference comment to GameTypes library Add a notice to the GameTypes library reminding developers to update the hardcoded game type lists in OPContractsManagerMigrator and OPContractsManagerV2's _assertValidFullConfig when adding new types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(contracts): bump OPContractsManagerV2 version for rebase Bump OPContractsManagerV2 from 7.0.9 to 7.0.10 to account for the comment-only source change (cross-reference note added in prior commit) that affects the bytecode metadata hash. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(contracts): bump OPContractsManagerV2 version to 7.0.11 for semver-diff CI fix * fix(contracts): apply forge fmt and bump versions for formatting changes forge fmt changed OPContractsManager, FaultDisputeGame, SuperFaultDisputeGame, and several other files. Bump patch versions for the contracts with hash changes, and regenerate semver-lock and snapshots. - OPContractsManager: 6.0.3 -> 6.0.4 - FaultDisputeGame: 2.4.0 -> 2.4.1 - SuperFaultDisputeGame: 0.7.0 -> 0.7.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: smartcontracts <smartcontracts@users.noreply.github.com>

Cantina audit finding #8: transferOwnership now nominates a pending owner who must call acceptOwnership() to finalize the transfer, preventing irrevocable ownership loss from incorrect addresses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs(staking): document pause bypass behavior in setAllowedStaker * fix(staking): only reset lastUpdate on full unstake in _decreasePeData Cantina audit finding #7: _decreasePeData unconditionally reset lastUpdate on every decrease, penalizing partial unstakers by resetting their staking weight. Now lastUpdate is only reset when effectiveStake reaches zero. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat(staking): implement two-step ownership transfer Cantina audit finding #8: transferOwnership now nominates a pending owner who must call acceptOwnership() to finalize the transfer, preventing irrevocable ownership loss from incorrect addresses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs(staking): document lastUpdate reset trust assumption in setAllowedStaker Cantina audit finding #10: when a beneficiary removes a staker from their allowlist, the staker's lastUpdate is reset via _increasePeData, losing accumulated staking weight. Document this as an inherent trust assumption of the delegation model. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: undo version change * chore: upgrade natspec * chore: update event emission order * fix: wrong event args * chore: add interface comments * fix: pre-pr * refactor: make ownable private functions public * fix: pre-pr * feat(ownable): reset pending owner on zeroaddress ownership transfer * refactor: inherit OZ's ownable and use helper contract for mapping storage slot * fix: ci --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

feat: add superchain erc20 factory

099a4c3

agusduha requested a review from 0xng July 19, 2024 19:52

fix: unit tests

614cfdb

0xng reviewed Jul 22, 2024

View reviewed changes

agusduha added 2 commits July 22, 2024 15:05

fix: refactor predeploys

d201a39

feat: refactor factory to have one deploy function

3a85e5b

agusduha added the hold Do not merge for now label Aug 8, 2024

agusduha closed this Aug 22, 2024

agusduha deleted the feat/add-superchain-erc20-factory branch August 22, 2024 15:16

0xiamflux pushed a commit that referenced this pull request Jan 27, 2026

Merge pull request #8 from alloy-rs/feat/op-alloy-consensus

35b4804

feat(consensus): op-alloy-consensus

0xiamflux pushed a commit that referenced this pull request Jan 27, 2026

Merge pull request #8 from ithacaxyz/klkvr/readme

613eafd

chore: update README

0xChin mentioned this pull request Mar 9, 2026

fix: staking audit fixes #892

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add superchain erc20 factory#8

feat: add superchain erc20 factory#8
agusduha wants to merge 4 commits intosuperc20from
feat/add-superchain-erc20-factory

agusduha commented Jul 19, 2024

Uh oh!

linear bot commented Jul 19, 2024

Uh oh!

0xng Jul 22, 2024

Uh oh!

agusduha Jul 22, 2024 •

edited

Loading

Uh oh!

0xng Jul 22, 2024

Uh oh!

agusduha Jul 22, 2024

Uh oh!

agusduha Jul 22, 2024

Uh oh!

0xng Jul 22, 2024

Uh oh!

0xng Jul 22, 2024

Uh oh!

0xng Jul 22, 2024

Uh oh!

0xng Jul 22, 2024

Uh oh!

agusduha commented Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

agusduha commented Jul 19, 2024

🤖 Linear

Uh oh!

linear bot commented Jul 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agusduha Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agusduha commented Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agusduha Jul 22, 2024 •

edited

Loading