Skip to content

test: opcm2 add read sup chain tests #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xiamflux merged 2 commits into from
Dec 11, 2025
Merged

test: opcm2 add read sup chain tests #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88527f7
chore: expand comment on ReadSuperchainDeployment.s.sol and init.go
0xiamflux Dec 11, 2025
d9cc8b9
test: add additional test cases for PopulateSuperchainState and InitL…
0xiamflux Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions op-deployer/pkg/deployer/pipeline/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,13 @@ func InitLiveStrategy(ctx context.Context, env *Env, intent *state.Intent, st *s
return fmt.Errorf("cannot set superchain roles for predeployed OPCM")
}

// Use OPCMv1 to populate superchain state
// Use OPCMv1 to populate superchain state.
// When using OPCMv1, we only provide the OPCM address (superchainConfigProxy is zero).
// The ReadSuperchainDeployment script (packages/contracts-bedrock/scripts/deploy/ReadSuperchainDeployment.s.sol)
// detects OPCM v1 mode when superchainConfigProxy is zero, then queries the OPCM contract to discover:
// - ProtocolVersions contract address via opcm.protocolVersions()
// - SuperchainConfig contract address via opcm.superchainConfig()
// - All related proxy admin addresses, implementations, and role addresses
superDeployment, superRoles, err := PopulateSuperchainState(env.L1ScriptHost, *intent.OPCMAddress, common.Address{})
if err != nil {
return fmt.Errorf("error populating superchain state: %w", err)
Expand All @@ -57,13 +63,21 @@ func InitLiveStrategy(ctx context.Context, env *Env, intent *state.Intent, st *s
}
}
}

hasSuperchainConfigProxy := intent.SuperchainConfigProxy != nil
if hasSuperchainConfigProxy && opcmV2Enabled {
if intent.SuperchainRoles != nil {
return fmt.Errorf("cannot set superchain roles for superchain config proxy")
}

// Use SuperchainConfigProxy to populate superchain state
// Use OPCMv2 to populate superchain state.
// When using OPCMv2, we provide the SuperchainConfigProxy address while the OPCM address is zero.
// The ReadSuperchainDeployment script (packages/contracts-bedrock/scripts/deploy/ReadSuperchainDeployment.s.sol)
// detects OPCM v2 mode when superchainConfigProxy is non-zero, then queries the SuperchainConfig contract
// to discover the implementation address, proxy admin, guardian, and proxy admin owner.
// In OPCMv2, ProtocolVersions is being removed. Therefore, the ProtocolVersions-related fields
// (protocolVersionsImpl, protocolVersionsProxy, protocolVersionsOwner, recommendedProtocolVersion,
// requiredProtocolVersion) are intentionally left uninitialized.
superDeployment, superRoles, err := PopulateSuperchainState(env.L1ScriptHost, common.Address{}, *intent.SuperchainConfigProxy)
if err != nil {
return fmt.Errorf("error populating superchain state: %w", err)
Expand Down
Loading