fix: sync#697
Conversation
…ather (ethereum-optimism#18369) * chore: Promote static cache pather * chore: Add runtime version check
* feat: OPCMv2 * fix: bug in deploying dispute games * fix: no more opcmv1 changes * fix: bad interface * fix: further clean diff * fix: reduce diff * fix: undo artifacts diffs * fix: broken go structs * fix: opcm output struct ordering * fix: better tests * fix: justfile path * fix: lcov issue * fix: pr review comments * fix: pr comments * fix: rebase tweaks * fix: contract verification failure * fix: last few ci issues
* Add DeployFeesDepositor script * Refactor deploy script to remove Output struct * forge fmt * Make logResults() pure * fix return value names * remove unused import * Apply suggestions from code review Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * Add missing natspec * Add natspec to tests --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
…ile (ethereum-optimism#18370) - update testContractExistsInFile() to match interfaces and libraries in addition to contracts - add test cases for interface and library validation in TestTestContractExistsInFile
…#18342) (ethereum-optimism#18348) * op-deployer: activate jovian at genesis by default (ethereum-optimism#18342) * op-deployer: activate jovian at genesis by default * fix tests for jovian activation * use inclusive instead of exclusive arg
* feat: add support for blockscout in VerifyOPCM This commit adds support for blockscout in VerifyOPCM and defaults to blockscout. Etherscan verification can still be used but blockscout is simpler and more reliable on all networks. * fix: formatting
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 16
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| // Transfer ownership of the ProxyAdmin to the proxyAdminOwner. | ||
| _cts.proxyAdmin.transferOwnership(_cfg.proxyAdminOwner); | ||
| } |
There was a problem hiding this comment.
Bug: DisputeGameFactory ownership lost during upgrades in OPCMV2
In the _apply function, the DisputeGameFactory is re-initialized with address(this) (the OPCM contract) as owner on line 757. However, ownership is only transferred back to the proxyAdminOwner when _isInitialDeployment is true (line 812). During upgrades (_isInitialDeployment == false), the ownership transfer is skipped, leaving the DisputeGameFactory owned by the OPCM contract instead of the proxyAdminOwner. The comment on lines 805-811 incorrectly assumes ownership would be preserved during upgrades, but the _upgrade function resets the initialized slot and calls the initializer, which sets the owner to OPCM. This causes the proxyAdminOwner to lose direct control over game configuration after any upgrade.
9 participants
Note
Introduce OPCM v2 with containerized impls, integrate across deploy/pipeline, add StorageSetter, switch default hardforks to Jovian, add GitHub binary version-checking, and update scripts/tests accordingly.
OPContractsManagerV2andOPContractsManagerContainer(blueprints/impls holder) with new ABIs/storage layouts andIOPContractsManagerV2,IOPContractsManagerContainer,IStorageSetter.StorageSetterimpl for safe re-initialization during upgrades.Deploy.s.solto supportOPCM_V2dev feature withdeployOpChainV2andgetDeployInputV2.DeployImplementations.s.solto deployOPCMV2,OPCMContainer, andStorageSetter; wire into artifacts.DeployFeesDepositor.s.soland tests.OPCM_V2to dev feature matrix; Semgrep exclusions and Foundry config for new paths.OPCMV2,OPCMContainer,StorageSetterImplfields to addresses, deployments, pipeline.DefaultHardforkSchedule()activatingforks.Jovian; update tests.VerifyOPCM: support Blockscout/Etherscan creation code fetch; add explorer config.OPContractsManagerV2upgrade tests; adjust existing tests to gate onOPCM_V2.Isthmus).Written by Cursor Bugbot for commit 59e972e. This will update automatically on new commits. Configure here.