Skip to content

feat: remove CGT dev feature flag#696

Merged
agusduha merged 1 commit intosc-feat/remove-cgt-dev-flagfrom
feat/remove-cgt-dev-flag
Nov 25, 2025
Merged

feat: remove CGT dev feature flag#696
agusduha merged 1 commit intosc-feat/remove-cgt-dev-flagfrom
feat/remove-cgt-dev-flag

Conversation

@agusduha
Copy link
Copy Markdown
Member

@agusduha agusduha commented Nov 24, 2025

Note

Removes the CUSTOM_GAS_TOKEN dev feature flag and switches all usage to system/config-based toggles, updating CI, deployer, and tests accordingly.

  • Dev features/config:
    • Remove CUSTOM_GAS_TOKEN from DevFeatures.sol, op-deployer (CustomGasTokenDevFlag), and env parsing (Config.devFeatureCustomGasToken).
    • Drop CGT from CI dev-feature matrices in .circleci/config.yml.
    • Feature flag resolver no longer reads DEV_FEATURE__CUSTOM_GAS_TOKEN.
  • Deployer:
    • Delete CGT dev flag; integration tests stop setting devFeatureBitmap for CGT and use Intent.CustomGasToken + validate SystemConfig feature.
  • Tests (L1/L2/Portal/bridges/fee modules/invariants):
    • Replace skipIfDevFeature* CGT checks with system-level toggles (setUseCustomGasToken(true) or enableCustomGasToken()); remove dev-feature gating throughout.
    • Add/rename CGT-specific test contracts and update test exclusions list.
    • Add CGT-mode variants for OptimismPortal2.depositTransaction/finalizeWithdrawal and L2ToL1MessagePasser tests; convert some checks to view where appropriate.
    • Invariants: switch funding to SafeSend.
  • CI:
    • Remove CGT from test matrices; minor workflow cleanups (e.g., add check_changed_patterns where needed).

Written by Cursor Bugbot for commit 433714e. This will update automatically on new commits. Configure here.

@agusduha agusduha requested a review from hexshire November 24, 2025 23:48
@agusduha agusduha self-assigned this Nov 24, 2025
Comment thread op-deployer/pkg/deployer/integration_test/apply_test.go
@hexshire hexshire self-requested a review November 25, 2025 17:42
@agusduha agusduha merged commit eb6bd0d into sc-feat/remove-cgt-dev-flag Nov 25, 2025
2 checks passed
@agusduha agusduha deleted the feat/remove-cgt-dev-flag branch November 25, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants