Skip to content

chore: improve test naming #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDiscotech merged 1 commit into from
Oct 23, 2025
Merged

chore: improve test naming #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/contracts-bedrock/test/L2/FeeVault.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,6 @@ abstract contract FeeVault_Uncategorized_Test is CommonTest {
feeVault.setWithdrawalNetwork(Types.WithdrawalNetwork.L2);
}

/// @notice Tests that the l1 fee wallet is correct.
function test_constructor_succeeds() external view {
assertEq(feeVault.RECIPIENT(), recipient);
assertEq(feeVault.MIN_WITHDRAWAL_AMOUNT(), minWithdrawalAmount);
assertEq(uint8(feeVault.WITHDRAWAL_NETWORK()), uint8(withdrawalNetwork));
}

/// @notice Tests that the initialize function succeeds.
function test_initialize_succeeds() external view {
assertEq(feeVault.recipient(), recipient);
Expand All @@ -55,6 +48,13 @@ abstract contract FeeVault_Uncategorized_Test is CommonTest {
feeVault.initialize(recipient, minWithdrawalAmount, Types.WithdrawalNetwork.L1);
}

/// @notice Tests that the immutable values match the storage getters.
function test_immutableMatchesStorageVariables_succeeds() external view {
assertEq(feeVault.RECIPIENT(), feeVault.recipient());
assertEq(feeVault.MIN_WITHDRAWAL_AMOUNT(), feeVault.minWithdrawalAmount());
assertEq(uint8(feeVault.WITHDRAWAL_NETWORK()), uint8(feeVault.withdrawalNetwork()));
}

/// @notice Tests that the fee feeVault is able to receive ETH.
function test_receive_succeeds() external {
uint256 balance = address(feeVault).balance;
Expand Down