Skip to content

fix: timestamp on initialize #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDiscotech merged 2 commits into from
Oct 29, 2025
Merged

fix: timestamp on initialize #645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a67fa4
feat: set block.timestamp to last interval on intiailzie
0xChin Oct 22, 2025
fa7f97c
chore: remove foundry.lock
0xChin Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions packages/contracts-bedrock/foundry.lock
View file
Open in desktop

@0xDiscotech 0xDiscotech Oct 23, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file??

Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"lib/forge-std": {
"rev": "6853b9ec7df5dc0c213b05ae67785ad4f4baa0ea"
},
"lib/kontrol-cheatcodes": {
"rev": "2c48ae1ab44228c199dca29414c0b4b18a3434e6"
},
"lib/lib-keccak": {
"rev": "3b1e7bbb4cc23e9228097cfebe42aedaf3b8f2b9"
},
"lib/openzeppelin-contracts": {
"rev": "ecd2ca2cd7cac116f7a37d0e474bbb3d7d5e1c4d"
},
"lib/openzeppelin-contracts-upgradeable": {
"rev": "0a2cb9a445c365870ed7a8ab461b12acf3e27d63"
},
"lib/openzeppelin-contracts-v5": {
"rev": "dbb6104ce834628e473d2173bbc9d47f81a9eec3"
},
"lib/safe-contracts": {
"branch": {
"name": "v1.4.1",
"rev": "186a21a74b327f17fc41217a927dea7064f74604"
}
},
"lib/solady": {
"rev": "502cc1ea718e6fa73b380635ee0868b0740595f0"
},
"lib/solady-v0.0.245": {
"rev": "e0ef35adb0ccd1032794731a995cb599bba7b537"
},
"lib/solmate": {
"rev": "8f9b23f8838670afda0fd8983f2c41e8037ae6bc"
},
"lib/superchain-registry": {
"rev": "84bce73573f130008d84bae6e924163bab589a11"
}
}
3 changes: 3 additions & 0 deletions packages/contracts-bedrock/src/L2/FeeSplitter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ contract FeeSplitter is ISemver, Initializable {
sharesCalculator = _sharesCalculator;
// As default, the fee disbursement interval is 1 day
feeDisbursementInterval = 1 days;

// Set the last disbursement time to the current block timestamp
lastDisbursementTime = uint128(block.timestamp);
}

/// @dev Receives ETH fees withdrawn from L2 FeeVaults.
Expand Down
1 change: 1 addition & 0 deletions packages/contracts-bedrock/test/L2/FeeSplitter.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ contract FeeSplitter_Initialize_Test is FeeSplitter_TestInit {

assertEq(address(IFeeSplitter(payable(impl)).sharesCalculator()), address(_defaultSharesCalculator));
assertEq(IFeeSplitter(payable(impl)).feeDisbursementInterval(), 1 days);
assertEq(IFeeSplitter(payable(impl)).lastDisbursementTime(), block.timestamp);
}

/// @notice Test that the implementation contract disables initializers in the constructor
Expand Down