Skip to content

fix(cgt): bound _mint correctly in depositTransaction test function #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xniha merged 1 commit into from
Sep 26, 2025
Merged

fix(cgt): bound _mint correctly in depositTransaction test function #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/contracts-bedrock/test/L1/OptimismPortal2.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2565,11 +2565,13 @@ contract OptimismPortal2_DepositTransaction_Test is OptimismPortal2_TestInit {
external
{
// Prevent overflow on an upgrade context
if (isUsingLockbox()) {
// Since the value always goes through the portal
_mint = bound(_mint, 0, type(uint256).max - address(optimismPortal2).balance);

if (isUsingLockbox() && address(optimismPortal2).balance > address(ethLockbox).balance) {
_mint = bound(_mint, 0, type(uint256).max - address(ethLockbox).balance);
} else {
_mint = bound(_mint, 0, type(uint256).max - address(optimismPortal2).balance);
}

if (isUsingCustomGasToken()) {
_mint = 0;
}
Expand All @@ -2585,7 +2587,6 @@ contract OptimismPortal2_DepositTransaction_Test is OptimismPortal2_TestInit {

uint256 balanceBefore = address(optimismPortal2).balance;
uint256 lockboxBalanceBefore = address(ethLockbox).balance;
_mint = bound(_mint, 0, type(uint256).max - balanceBefore);

// EOA emulation
vm.expectEmit(address(optimismPortal2));
Expand Down