Skip to content

fix: integration fuzz test edge case #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDiscotech merged 1 commit into from
Sep 26, 2025
Merged

fix: integration fuzz test edge case #615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/contracts-bedrock/test/L2/RevenueSharingIntegration.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,9 @@ contract RevenueSharingIntegration_Test is CommonTest {
_operatorFees2 = bound(_operatorFees2, 0, 100 ether);
_l1Fees2 = bound(_l1Fees2, 0, 100 ether);

// Handle case where first disbursement has all zero fees
if (_l1Fees == 0 && _sequencerFees == 0 && _baseFees == 0 && _operatorFees == 0) {
// Handle case where grossShare == 0
// It is 0 when it sums up to less than 40 because of the GROSS_SHARE_BPS = 250 and BASIS_POINT_SCALE = 10_000
if (_l1Fees + _sequencerFees + _baseFees + _operatorFees < 40) {
vm.expectRevert(ISuperchainRevSharesCalculator.SharesCalculator_ZeroGrossShare.selector);
superchainRevSharesCalculator.getRecipientsAndAmounts(_sequencerFees, _baseFees, _operatorFees, _l1Fees);
return;
Expand Down Expand Up @@ -351,8 +352,9 @@ contract RevenueSharingIntegration_Test is CommonTest {

// ========== SECOND DISBURSEMENT ==========

// Handle case where second disbursement has all zero fees
if (_l1Fees2 == 0 && _sequencerFees2 == 0 && _baseFees2 == 0 && _operatorFees2 == 0) {
// Handle case where grossShare == 0
// It is 0 when it sums up to less than 40 because of the GROSS_SHARE_BPS = 250 and BASIS_POINT_SCALE = 10_000
if (_l1Fees2 + _sequencerFees2 + _baseFees2 + _operatorFees2 < 40) {
vm.expectRevert(ISuperchainRevSharesCalculator.SharesCalculator_ZeroGrossShare.selector);
superchainRevSharesCalculator.getRecipientsAndAmounts(_sequencerFees2, _baseFees2, _operatorFees2, _l1Fees2);
return;
Expand Down