Skip to content

fix: warnings #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDiscotech merged 3 commits into from
Sep 18, 2025
Merged

fix: warnings #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3424ba9
fix: shadow warning
0xDiscotech Sep 18, 2025
f17d223
fix: update interfaces constructor params
0xDiscotech Sep 18, 2025
69fe4e7
chore: undo interfaces changes
0xDiscotech Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/contracts-bedrock/interfaces/L2/IFeeVault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ interface IFeeVaultConstructor {
/// it is an abstract contract, and on the scripts it gets an empty constructor automatically generated that
/// makes the `interfaces-check` script fail.
function __constructor__(
address _recipient,
uint256 _minWithdrawalAmount,
Types.WithdrawalNetwork _withdrawalNetwork
address __recipient,
uint256 __minWithdrawalAmount,
Types.WithdrawalNetwork __withdrawalNetwork
)
external;
}
15 changes: 8 additions & 7 deletions packages/contracts-bedrock/src/L2/FeeVault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,14 @@ abstract contract FeeVault {
Types.WithdrawalNetwork oldWithdrawalNetwork, Types.WithdrawalNetwork newWithdrawalNetwork
);

/// @param _recipient Wallet that will receive the fees.
/// @param _minWithdrawalAmount Minimum balance for withdrawals.
/// @param _withdrawalNetwork Network which the recipient will receive fees on.
constructor(address _recipient, uint256 _minWithdrawalAmount, Types.WithdrawalNetwork _withdrawalNetwork) {
RECIPIENT = _recipient;
MIN_WITHDRAWAL_AMOUNT = _minWithdrawalAmount;
WITHDRAWAL_NETWORK = _withdrawalNetwork;
/// @dev Using `__` on params to avoid warnings related to shadowing (even though there is no shadowing)
/// @param __recipient Wallet that will receive the fees.
/// @param __minWithdrawalAmount Minimum balance for withdrawals.
/// @param __withdrawalNetwork Network which the recipient will receive fees on.
constructor(address __recipient, uint256 __minWithdrawalAmount, Types.WithdrawalNetwork __withdrawalNetwork) {
RECIPIENT = __recipient;
MIN_WITHDRAWAL_AMOUNT = __minWithdrawalAmount;
WITHDRAWAL_NETWORK = __withdrawalNetwork;
}

/// @notice Allow the contract to receive ETH.
Expand Down