Skip to content

fix: failing tests#553

Merged
0xDiscotech merged 6 commits intosc-feat/fee-splitter-systemfrom
fix/fee-splitter-tests
Sep 17, 2025
Merged

fix: failing tests#553
0xDiscotech merged 6 commits intosc-feat/fee-splitter-systemfrom
fix/fee-splitter-tests

Conversation

@0xDiscotech
Copy link
Copy Markdown

@0xDiscotech 0xDiscotech commented Sep 16, 2025

  • Fixed failing just test tests
  • Completed coverage for FeeSplitter

@0xDiscotech 0xDiscotech self-assigned this Sep 16, 2025
@0xDiscotech 0xDiscotech marked this pull request as ready for review September 16, 2025 21:42
0xiamflux
0xiamflux previously approved these changes Sep 16, 2025
Comment thread packages/contracts-bedrock/test/L2/FeeSplitter.t.sol Outdated
@0xDiscotech 0xDiscotech merged commit 024a674 into sc-feat/fee-splitter-system Sep 17, 2025
1 check passed
@0xDiscotech 0xDiscotech deleted the fix/fee-splitter-tests branch September 17, 2025 17:26
agusduha pushed a commit that referenced this pull request Nov 7, 2025
* feat: fee splitter system (#469)


----

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>

* fix: failing tests (#553)

* refactor: revenue sharing config (#538)

* fix: pre pr and semgrep (#565)

* fix: warnings (#571)

* fix: tests failing on fork environment (#575)

* fix: use encode call on constructors (#578)

* feat: add integration splitter test (#581)

* fix: integration test nits (#583)

* test: more coverage on splitter tests (#594)


---------

Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>

* fix: add missing operator fee vault field (#616)

* feat: invariants and tests (#595)

* fix: ir informationals (#609)

* fix: pre pr (#622)

* refactor: use cdm (#624)

* fix: update withdrawal gas limit value on check (#627)

* fix: remove rev share field from deploy op chain input struct (#628)

* refactor: remove initializer and vaults getter changes (#631)

* fix: remove immutable check over vaults (#634)


Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>
Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com>
Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>

* fix: audit findings (#658)

* fix: pre pr

* feat: add user guide docs for rev sharing on op deployer (#666)

* docs: add create2 comment (#667)

---------

Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com>
Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com>
Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>
Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
0xDiscotech added a commit that referenced this pull request Dec 2, 2025
* feat: fee splitter system (#469)

----

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>

* fix: failing tests (#553)

* refactor: revenue sharing config (#538)

* fix: pre pr and semgrep (#565)

* fix: warnings (#571)

* fix: tests failing on fork environment (#575)

* fix: use encode call on constructors (#578)

* feat: add integration splitter test (#581)

* fix: integration test nits (#583)

* test: more coverage on splitter tests (#594)

---------

Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>

* fix: add missing operator fee vault field (#616)

* feat: invariants and tests (#595)

* fix: ir informationals (#609)

* fix: pre pr (#622)

* refactor: use cdm (#624)

* fix: update withdrawal gas limit value on check (#627)

* fix: remove rev share field from deploy op chain input struct (#628)

* refactor: remove initializer and vaults getter changes (#631)

* fix: remove immutable check over vaults (#634)

Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>
Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com>
Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>

* fix: audit findings (#658)

* fix: pre pr

* feat: add user guide docs for rev sharing on op deployer (#666)

* docs: add create2 comment (#667)

---------

Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com>
Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com>
Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>
Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants