Closed
Conversation
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
0xniha
added a commit
that referenced
this pull request
Mar 3, 2026
0xOneTony
pushed a commit
that referenced
this pull request
Mar 4, 2026
…16 (ethereum-optimism#19271) Add missing @param blueprint NatSpec to OpcmContractRef struct (#2). Add comments about pause blocking interop upgrades (#3). Document migrate() scope limitations and re-migration risks (#7, #15). Update PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional use of chainSystemConfigs[0] for shared contracts (#16). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
0xChin
pushed a commit
that referenced
this pull request
Mar 9, 2026
…eum-optimism#19424) The 5s timeout is too tight under CI load. When 12 parallel test nodes compete for CPU/IO on a 2xlarge box, Anvil sometimes takes >5s to print its "Listening on" line, triggering "anvil did not start in time" in TestImplementations and TestSuperchain. This is the #2 and #3 most frequent flake in the repo over the last 7 days (67 and 46 incidences). 30s gives Anvil enough headroom on a loaded machine while still failing fast on a genuine startup failure. Co-authored-by: smartcontracts <smartcontracts@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
0xniha
added a commit
that referenced
this pull request
Mar 9, 2026
* feat: add nut lib * refactor: remove newTx function from nut lib * feat: add GenerateNUTBundle script * fix: pre-pr fixes * test: add generate bundle utils tests * refactor: replace custom computeCreate2Address by forge's * docs: fix and add natspec * fix: remove script inheritance from utils contract * refactor: remove unnecesary fields from nut tx struct & replace sourcehash by intent * test: add create tx empry args equivalence and different salts assumption * refactor: remove fork, salt and cgt from bundle script input & consolidate utils into UpgradeUtils * refactor: remove fork, salt and cgt from bundle script input * refactor: comments and constants * refactor: consolidate nut bundle utilities into UpgradeUtils * fix: proxy admin get code * fix: remove unused import Fork * fix: rm L2ContractsManagerTypes * fix: update impl struct and make lib functions internal * feat: remove TODO for L2CM merge and add TODO for OptimismMintableERC721Factory initializable upgrade * test: complete nuts structure testing * feat: add metadata struct to bundle * feat: make OptimismMintableERC721Factory initializable * fix: replace jovian for karst * fix: add Initialized event to IOptimismMintableERC721Factory * fix: remove check immutable in apply tests * fix: outdated safety invariants * fix: add OptimismMintableERC721FactoryLegacyMapping * refactor: rm upgrade name from intent, add upgradeBundlePath helper and add TODO for karst nuts removal * feat: add invariant #2 to L2ProxyAdmin * feat: add nut bundle check, just script and ci check * feat: add implementation count check * docs: add array string clarification comment * feat: add regex check for metadata version and 'to' field comment * fix: remove salt standard todo comment * fix: remove old upgrade OptimismMintableERC721Factory call and fix initializable slot * feat: add IOptimismMintableERC721FactoryLegacyMapping * fix: run pre-pr * fix: run pre-pr * fix: remove owner argument for L2PA constructor and set owner to zero address * fix: remove gitkeep * fix: storage gap in OptimismMintableERC721Factory * refactor: make bundle file name generic * fix: remove duplicated assert * fix: l2genesis proxy admin impl owner test * fix: l2pa createAdmin with manual storage setting test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illustrative code changes to be made for the
L2toL2CrossDomainMessengercontract. This code should never be used in production. For more context please take a look at:Stuck Messages