Merged
Conversation
0xDiscotech
reviewed
Nov 1, 2024
0xDiscotech
previously approved these changes
Nov 1, 2024
0xParti
reviewed
Nov 1, 2024
| /// bridging to make it fungible across the Superchain. This construction allows the SuperchainTokenBridge to | ||
| /// burn and mint tokens. | ||
| abstract contract SuperchainERC20 is ERC20, ICrosschainERC20, ISemver { | ||
| abstract contract SuperchainERC20 is ERC20, ERC165, IERC7802, ISemver { |
There was a problem hiding this comment.
cant we make the IERC7802 include IERC165?
| /// @title IERC7802 | ||
| /// @notice Defines the interface for crosschain ERC20 transfers. | ||
| interface ICrosschainERC20 { | ||
| interface IERC7802 is IERC165 { |
There was a problem hiding this comment.
if you include it here, do you need to include in the implementation contract as well?
Member
Author
There was a problem hiding this comment.
This one is for the interface to enforce it to be included when extending from it
The other one is an abstract contract that has the OZ implementation, it particularly declares supporting the IERC165 interface
One solution is to stop inheriting from ERC165 but manually add the interface support to each contract in the supportInterface function
0xDiscotech
approved these changes
Nov 1, 2024
0xParti
approved these changes
Nov 1, 2024
gotzenx
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes OPT-501
Changes:
ICrosschainERC20toIERC7802ERC165SuperchainTokenBridgewithERC165just pre-prandjust testsucceeded