Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic architecture #1

Merged
merged 6 commits into from
Jul 16, 2024
Merged

feat: basic architecture #1

merged 6 commits into from
Jul 16, 2024

Conversation

0xtiti
Copy link
Collaborator

@0xtiti 0xtiti commented Jul 12, 2024 •
edited
Loading

closes ZKS-104

Description:

  • Create a DataProvider that will handle all requests

@linear Linear
Copy link

linear bot commented Jul 12, 2024

ZKS-104 Create a DataProvider that will handle all requests

this provider should have:

  • one function that fetch the ecosystem data using react-query
  • one function that fetch the given chain data using react-query

@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
z-kchain-hub-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 7:56pm

@defi-wonderland defi-wonderland deleted a comment from linear bot Jul 12, 2024
@0xtiti 0xtiti marked this pull request as ready for review July 12, 2024 20:49
@0xtiti 0xtiti requested a review from 0xArdy July 12, 2024 20:54
0xArdy
0xArdy reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work!

just a couple of small comments

src/providers/index.tsx Outdated Show resolved Hide resolved
src/providers/DataProvider.tsx Outdated Show resolved Hide resolved
@0xtiti 0xtiti requested a review from 0xArdy July 15, 2024 20:19
0xArdy
0xArdy approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@0xtiti 0xtiti merged commit 1c3d621 into dev Jul 16, 2024
6 checks passed
@0xtiti 0xtiti deleted the feat/basic-architecture branch July 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agusduha agusduha agusduha approved these changes

@0xArdy 0xArdy 0xArdy approved these changes

@turtlemoji turtlemoji Awaiting requested review from turtlemoji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xtiti @agusduha @0xArdy