Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate HorizonAccountingExtension #37

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

feat: integrate HorizonAccountingExtension #37

wants to merge 16 commits into from
+683 −509

Conversation

0xJabberwock
Copy link
Member

🤖 Linear

Closes GRT-185

@0xJabberwock 0xJabberwock self-assigned this Sep 23, 2024
@linear Linear
Copy link

linear bot commented Sep 23, 2024

GRT-185 Integrate `HorizonAccountingExtension`

@0xJabberwock 0xJabberwock force-pushed the test/horizon-accounting-extension-integration branch from adff81e to 845f0a3 Compare September 25, 2024 21:22
0xShaito
0xShaito requested changes Sep 26, 2024
View reviewed changes
script/Deploy.s.sol Outdated Show resolved Hide resolved
script/Deploy.s.sol Show resolved Hide resolved
@0xJabberwock 0xJabberwock mentioned this pull request Oct 1, 2024
Merged
0xJabberwock
0xJabberwock commented Oct 3, 2024
View reviewed changes
Copy link
Member Author

@0xJabberwock 0xJabberwock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARBITRUM_RPC contained in the repo's secrets should change from Arbitrum Mainnet to Arbitrum Sepolia for the integration tests to be run successfully by GitHub Actions.

0xShaito
0xShaito reviewed Oct 5, 2024
View reviewed changes
Copy link
Member

@0xShaito 0xShaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@0xJabberwock 0xJabberwock marked this pull request as ready for review October 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xShaito 0xShaito 0xShaito approved these changes

Assignees

@0xJabberwock 0xJabberwock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xJabberwock @0xShaito