Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (dpluger) add aggregation key type checking #381

Merged
merged 8 commits into from
Feb 20, 2022

Conversation

rkspx
Copy link
Contributor

@rkspx rkspx commented Feb 20, 2022

  • add type checking for aggregation key conversion, this prevent panic when the resulted aggregation key isn't float64

@rkspx rkspx requested a review from mmta as a code owner February 20, 2022 09:15
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #381 (5efffc6) into master (d96480f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   96.72%   96.78%   +0.06%     
==========================================
  Files          45       45              
  Lines        3175     3175              
==========================================
+ Hits         3071     3073       +2     
+ Misses         76       74       -2     
  Partials       28       28              
Impacted Files Coverage Δ
internal/pkg/dsiem/worker/worker.go 97.61% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d96480f...5efffc6. Read the comment docs.

@rkspx rkspx merged commit 9e4fa31 into master Feb 20, 2022
@mergify mergify bot deleted the dpluger/aggregation_key_type_checking branch February 20, 2022 17:07
@defenbot
Copy link

🎉 This PR is included in version 0.32.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants