Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize repo to template and update README.md #20

Merged
merged 10 commits into from
Feb 14, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Feb 5, 2024

@Racer159 Racer159 requested a review from a team as a code owner February 5, 2024 04:09
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate convo but it is blocking this and other PRs - was there a discussion on adding required checks of Test / Test here / in other repos? It doesn't match the current workflows so it seems premature to change, also don't love Test / Test as the name but whatever gets PRs unblocked is okay.

Edit: we will need to account for the flavors regardless, so maybe Test / <flavor> or similar?

SECURITY.md Outdated Show resolved Hide resolved
@zachariahmiller
Copy link
Contributor

@Racer159 Just a note. The named required checks were changed and they were not changed in this PR, please update the required tests.

Even if its changed to "Test/Test" it will still fail to pass as there is a matrix on flavors. FWIW I think Test/Test is kind of unnecessary.

Despite the fact that it is literally testing a deployment (hence Test/Deploy) I understand how "deploy" could mean something more specific to someone. If we are going to change the workflow names lets at least remove the redundancy and allow more room to add additional tests.

Based on that I'd recommend we update the job names to "Test / " for example "Test / Install upstream". That will allow us to, as needed, test upgrades by themselves. Especially for something like gitlab that might be a pain to only test upgrades in the integration repos with the rest of SWF.

Racer159 and others added 4 commits February 5, 2024 12:09
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
@Racer159 Racer159 marked this pull request as draft February 5, 2024 21:50
@Racer159 Racer159 marked this pull request as ready for review February 14, 2024 03:51
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged a separate renovate PR before noticing this one was ready to go 😅

@mjnagel mjnagel enabled auto-merge (squash) February 14, 2024 14:09
@mjnagel mjnagel merged commit 88a3d84 into main Feb 14, 2024
3 checks passed
@mjnagel mjnagel deleted the hotfix-create-standardized-repo-template branch February 14, 2024 14:12
@Racer159 Racer159 mentioned this pull request Feb 15, 2024
Racer159 added a commit that referenced this pull request May 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[9.7.2-uds.1](v9.7.2-uds.1...v9.7.2-uds.1)
(2024-05-10)


### ⚠ BREAKING CHANGES

* add monitoring and granular netpols
([#67](#67))

### Features

* add irsa/sa auth support
([f178a54](f178a54))
* add irsa/sa auth support
([c3d5acb](c3d5acb))
* add monitoring and granular netpols
([#67](#67))
([915eb2d](915eb2d))
* burn the boats
([d25c6bb](d25c6bb))
* env var MM_SQLSETTINGS_DATASOURCE set
([#54](#54))
([16894df](16894df))
* integrate with keycloak
([#44](#44))
([ce05b45](ce05b45))
* update readme
([7f5162b](7f5162b))
* Update README.md
([7e9f97b](7e9f97b))


### Bug Fixes

* expose plugin upload setting
([#12](#12))
([f8fbfc2](f8fbfc2))
* fix mm hostname
([516569a](516569a))
* fix mm hostname and tests
([785384d](785384d))
* fix tests for mm
([c660e66](c660e66))
* handle subdomain shared between packages
([#10](#10))
([31da0b4](31da0b4))


### Miscellaneous

* add 🏭 to README.md
([9e4c566](9e4c566))
* **deps:** update all dependencies
([#16](#16))
([e54ebc6](e54ebc6))
* **deps:** update githubactions
([#17](#17))
([a24855a](a24855a))
* **deps:** update githubactions
([#22](#22))
([d1cf997](d1cf997))
* **deps:** update mattermost package dependencies
([#42](#42))
([8da95ef](8da95ef))
* **deps:** update mattermost package dependencies
([#48](#48))
([10b24e9](10b24e9))
* **deps:** update mattermost package dependencies
([#59](#59))
([edf154b](edf154b))
* **deps:** update mattermost support dependencies
([#46](#46))
([2a9d055](2a9d055))
* **deps:** update mattermost support dependencies
([#55](#55))
([fe798f6](fe798f6))
* **deps:** update mattermost support dependencies
([#63](#63))
([6010a04](6010a04))
* fix renovate config to only allow semver on mattermost image
([#51](#51))
([65e294f](65e294f))
* hotfix renovate config registries
([#45](#45))
([42a912b](42a912b))
* implement upgrade tests for mattermost
([43044cf](43044cf))
* **main:** release 9.3.0-uds.1
([41da032](41da032))
* **main:** release 9.3.0-uds.2
([c4381ae](c4381ae))
* **main:** release 9.4.1-uds.0
([#8](#8))
([5415a0a](5415a0a))
* **main:** release 9.4.1-uds.1
([#11](#11))
([8f73182](8f73182))
* **main:** release 9.4.1-uds.2
([#13](#13))
([e177cbe](e177cbe))
* **main:** release 9.4.1-uds.3
([e57f69a](e57f69a))
* **main:** release 9.4.1-uds.4
([#40](#40))
([6c7549f](6c7549f))
* **main:** release 9.6.1-uds.0
([#47](#47))
([3e52b95](3e52b95))
* **main:** release 9.7.1-uds.0
([#52](#52))
([acda0c5](acda0c5))
* **main:** release 9.7.2-uds.0
([#60](#60))
([32eb363](32eb363))
* **main:** release 9.7.2-uds.1
([#64](#64))
([fcf56e0](fcf56e0))
* release 9.4.1-uds.0
([5b89960](5b89960))
* release 9.6.1-uds.0
([#49](#49))
([37ef4ad](37ef4ad))
* release as v9.7.2-uds.0
([#62](#62))
([bc0b65f](bc0b65f))
* renovate config, remote tasks
([#14](#14))
([bb6c574](bb6c574))
* standardize repo to template and update README.md
([#20](#20))
([88a3d84](88a3d84))
* update CODEOWNERS to new style/group
([27246ca](27246ca))
* update extraEnv to envFrom
([#58](#58))
([57df25a](57df25a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants