Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a secret generation function to setup the Database #145

Closed
Racer159 opened this issue Jun 11, 2024 · 0 comments · Fixed by #147
Closed

Implement a secret generation function to setup the Database #145

Racer159 opened this issue Jun 11, 2024 · 0 comments · Fixed by #147
Assignees
@Racer159
Labels
enhancement ✨ New feature or request

Comments

@Racer159
Copy link
Contributor

Racer159 commented Jun 11, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

As Ezra I want a way to manually setup the database directly with the config chart so that I do not need to manage a package out of band in a bundle for this.

Describe the solution you'd like

  • Given I have an endpoint and a username and password for the database.
  • When I provide these under the appropriate key (postgres) to the config chart.
  • Then the config chart generates the appropriate secrets for this service.

Describe alternatives you've considered

We could keep the status quo and change Mattermost to not have this pattern but this pattern is a nice to have when you need to manually provide a username / password.

Additional context

This is similar to the pattern Mattermost uses and should be done similarly from a Helm values perspective: https://github.com/defenseunicorns/uds-package-mattermost/blob/fce7636395d1e3afab5fcf8a502c084bd21a8a83/chart/values.yaml#L12
@Racer159 Racer159 added the enhancement ✨ New feature or request label Jun 11, 2024
@Racer159 Racer159 changed the title Implement a secret generation function to setup the Database, Object Storage and Redis Implement a secret generation function to setup the Database Jun 11, 2024
@Racer159 Racer159 self-assigned this Jun 11, 2024
@blancharda blancharda mentioned this issue Jun 11, 2024
Open
@Racer159 Racer159 mentioned this issue Jun 12, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue Jun 12, 2024
@Racer159
feat: allow for Postgres password secret generation (#147)
5d48380 
## Description

This allows for the Postgres password secret to be generated in the
config chart directly

## Related Issue

Fixes #145 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow for Postgres password secret generation defenseunicorns/uds-package-gitlab
1 participant
@Racer159