Skip to content

fix: add credential deletion configuration#398

Merged
chance-coleman merged 3 commits intomainfrom
allow-deleting-a-passkey
Mar 31, 2025
Merged

fix: add credential deletion configuration#398
chance-coleman merged 3 commits intomainfrom
allow-deleting-a-passkey

Conversation

@chance-coleman
Copy link
Copy Markdown
Contributor

@chance-coleman chance-coleman commented Mar 28, 2025

Description

With the addition of WebAuthn Passkeys, there wasn't a way for a user to delete and re-create a passkey attached to their accound. This change allows for that use case.

These changes don't change the existing behavior of core or identity config.

Testing Steps

  1. Clone in the uds-core branch git clone https://github.com/defenseunicorns/uds-core.git && cd uds-core && git checkout allow-deleting-a-passkey && cd ../
  2. comment out the task clone-core here: https://github.com/defenseunicorns/uds-identity-config/blob/main/tasks.yaml#L117
  3. deploy identity config uds run uds-core-integration-tests
  4. navigate to sso.uds.dev and register a new user with a passkey
  5. in the users account console go to the Account Security -> Signing in page
  6. in the Two Factor Authentication section you should see an entry for the passkeys, and notably beside those there should not be a bold red Delete button
  7. configure the bundle and disable the registration fields:
            - path: realmAuthFlows
              value:
                USERNAME_PASSWORD_AUTH_ENABLED: true
                X509_AUTH_ENABLED: true
                SOCIAL_AUTH_ENABLED: true
                OTP_ENABLED: false
                WEBAUTHN_ENABLED: true
                X509_MFA_ENABLED: true
  1. deploy identity config again uds run uds-core-integration-tests
  2. This time register a user with a passkey and verify that there is a big red Delete button next to the passkey

Related Issue

Fixes #397
Relates to this UDS Core PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@chance-coleman chance-coleman self-assigned this Mar 28, 2025
@chance-coleman chance-coleman linked an issue Mar 28, 2025 that may be closed by this pull request
@chance-coleman chance-coleman marked this pull request as ready for review March 28, 2025 20:57
@chance-coleman chance-coleman requested a review from a team as a code owner March 28, 2025 20:57
Comment thread src/realm.json
chance-coleman added a commit to defenseunicorns/uds-core that referenced this pull request Mar 31, 2025
## Description
After enabling webauthn passkeys, we need to be able to allow users to
delete their passkey so that they can re-add that passkey.

These changes don't change the existing behavior of core or identity
config.

## Related Issue

Relates to this Identity Config
[issue](defenseunicorns/uds-identity-config#397)
Relates to this Identity Config
[PR](defenseunicorns/uds-identity-config#398)

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate
- steps to validate will be in [the identity-config
PR](defenseunicorns/uds-identity-config#398)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
@chance-coleman chance-coleman merged commit 83bc044 into main Mar 31, 2025
11 checks passed
noahpb pushed a commit to defenseunicorns/uds-core that referenced this pull request Apr 2, 2025
## Description
After enabling webauthn passkeys, we need to be able to allow users to
delete their passkey so that they can re-add that passkey.

These changes don't change the existing behavior of core or identity
config.

## Related Issue

Relates to this Identity Config
[issue](defenseunicorns/uds-identity-config#397)
Relates to this Identity Config
[PR](defenseunicorns/uds-identity-config#398)

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate
- steps to validate will be in [the identity-config
PR](defenseunicorns/uds-identity-config#398)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
## Description
After enabling webauthn passkeys, we need to be able to allow users to
delete their passkey so that they can re-add that passkey.

These changes don't change the existing behavior of core or identity
config.

## Related Issue

Relates to this Identity Config
[issue](defenseunicorns/uds-identity-config#397)
Relates to this Identity Config
[PR](defenseunicorns/uds-identity-config#398)

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate
- steps to validate will be in [the identity-config
PR](defenseunicorns/uds-identity-config#398)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow deleting a passkey

3 participants