fix: add credential deletion configuration#398
Merged
chance-coleman merged 3 commits intomainfrom Mar 31, 2025
Merged
Conversation
5 tasks
mjnagel
reviewed
Mar 28, 2025
chance-coleman
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Mar 31, 2025
## Description After enabling webauthn passkeys, we need to be able to allow users to delete their passkey so that they can re-add that passkey. These changes don't change the existing behavior of core or identity config. ## Related Issue Relates to this Identity Config [issue](defenseunicorns/uds-identity-config#397) Relates to this Identity Config [PR](defenseunicorns/uds-identity-config#398) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Steps to Validate - steps to validate will be in [the identity-config PR](defenseunicorns/uds-identity-config#398) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed
mjnagel
approved these changes
Mar 31, 2025
noahpb
pushed a commit
to defenseunicorns/uds-core
that referenced
this pull request
Apr 2, 2025
## Description After enabling webauthn passkeys, we need to be able to allow users to delete their passkey so that they can re-add that passkey. These changes don't change the existing behavior of core or identity config. ## Related Issue Relates to this Identity Config [issue](defenseunicorns/uds-identity-config#397) Relates to this Identity Config [PR](defenseunicorns/uds-identity-config#398) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Steps to Validate - steps to validate will be in [the identity-config PR](defenseunicorns/uds-identity-config#398) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed
mjnagel
pushed a commit
to BagelLab/uds-core
that referenced
this pull request
Nov 14, 2025
## Description After enabling webauthn passkeys, we need to be able to allow users to delete their passkey so that they can re-add that passkey. These changes don't change the existing behavior of core or identity config. ## Related Issue Relates to this Identity Config [issue](defenseunicorns/uds-identity-config#397) Relates to this Identity Config [PR](defenseunicorns/uds-identity-config#398) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Steps to Validate - steps to validate will be in [the identity-config PR](defenseunicorns/uds-identity-config#398) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the addition of WebAuthn Passkeys, there wasn't a way for a user to delete and re-create a passkey attached to their accound. This change allows for that use case.
These changes don't change the existing behavior of core or identity config.
Testing Steps
git clone https://github.com/defenseunicorns/uds-core.git && cd uds-core && git checkout allow-deleting-a-passkey && cd ../clone-corehere: https://github.com/defenseunicorns/uds-identity-config/blob/main/tasks.yaml#L117uds run uds-core-integration-testssso.uds.devand register a new user with a passkeyAccount Security->Signing inpageTwo Factor Authenticationsection you should see an entry for the passkeys, and notably beside those there should not be a bold redDeletebuttonuds run uds-core-integration-testsDeletebutton next to the passkeyRelated Issue
Fixes #397
Relates to this UDS Core PR
Type of change
Checklist before merging