Skip to content

fix: rename disable registration fields#396

Merged
chance-coleman merged 6 commits intomainfrom
move-registration-env
Apr 4, 2025
Merged

fix: rename disable registration fields#396
chance-coleman merged 6 commits intomainfrom
move-registration-env

Conversation

@chance-coleman
Copy link
Copy Markdown
Contributor

@chance-coleman chance-coleman commented Mar 28, 2025 •
edited
Loading

Description

With the new theme customization work, moving the environment variable for disabling registration fields into the new themeCustomizations block since it's only theme related.

Testing

  1. Clone in the uds-core branch git clone https://github.com/defenseunicorns/uds-core.git && cd uds-core && git checkout move-registration-env && cd ../
  2. comment out the task clone-core here: https://github.com/defenseunicorns/uds-identity-config/blob/main/tasks.yaml#L117
  3. deploy identity config uds run uds-core-integration-tests
  4. navigate to sso.uds.dev and click the register button
  5. by default the registration fields should still be there
  6. configure the bundle and disable the registration fields:
            - path: themeCustomizations
              value:
                DISABLE_REGISTRATION_FIELDS: true
  1. deploy identity config again uds run uds-core-integration-tests
  2. Verify that when registering new user at sso.uds.dev there is no registration fields present anymore

Related Issue

Fixes #395
Related to this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@chance-coleman chance-coleman self-assigned this Mar 28, 2025
@chance-coleman chance-coleman mentioned this pull request Mar 28, 2025
Merged
5 tasks
slaskawi
slaskawi reviewed Mar 30, 2025
View reviewed changes
Comment thread docs/reference/UDS Core/IdAM/customization.md Outdated
@chance-coleman chance-coleman marked this pull request as ready for review April 2, 2025 16:56
@chance-coleman chance-coleman requested a review from a team as a code owner April 2, 2025 16:56
@chance-coleman chance-coleman merged commit 1e7c874 into main Apr 4, 2025
11 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 3, 2025
Merged
chance-coleman added a commit to defenseunicorns/uds-core that referenced this pull request Apr 4, 2025
@chance-coleman
fix!: move disable registration fields to theme values (#1397)
61c67f0 
## Description
With the new theme customization work, moving the environment variable
for disabling registration fields into the new `themeCustomizations`
block since it's only theme related.

## Related Issue

[Fixes this
issue](defenseunicorns/uds-identity-config#395)
[Related to this
PR](defenseunicorns/uds-identity-config#396)

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate
- Steps to test are in the [identity config
PR](defenseunicorns/uds-identity-config#396)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
noahpb pushed a commit to defenseunicorns/uds-core that referenced this pull request Apr 17, 2025
@chance-coleman @noahpb
fix!: move disable registration fields to theme values (#1397)
0c6a4e5 
## Description
With the new theme customization work, moving the environment variable
for disabling registration fields into the new `themeCustomizations`
block since it's only theme related.

## Related Issue

[Fixes this
issue](defenseunicorns/uds-identity-config#395)
[Related to this
PR](defenseunicorns/uds-identity-config#396)

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate
- Steps to test are in the [identity config
PR](defenseunicorns/uds-identity-config#396)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@chance-coleman @mjnagel
fix!: move disable registration fields to theme values (defenseunicor…
67466b3 
…ns#1397)

## Description
With the new theme customization work, moving the environment variable
for disabling registration fields into the new `themeCustomizations`
block since it's only theme related.

## Related Issue

[Fixes this
issue](defenseunicorns/uds-identity-config#395)
[Related to this
PR](defenseunicorns/uds-identity-config#396)

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate
- Steps to test are in the [identity config
PR](defenseunicorns/uds-identity-config#396)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slaskawi slaskawi slaskawi approved these changes

@mjnagel mjnagel mjnagel approved these changes

Assignees

@chance-coleman chance-coleman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move DISABLE_REGISTRATION_FIELDS under the themeCustomizations

3 participants

@chance-coleman @slaskawi @mjnagel