Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sort auth chains when building the authservice config #969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sort auth chains when building the authservice config #969

wants to merge 1 commit into from

Conversation

catsby
Copy link

@catsby catsby commented Oct 28, 2024 •
edited
Loading

Description

Sort auth chain after adding to authservice to ensure consistent ordering. Note that this is my first dive in to Typescript so please let me know where I could do things better here.

Related Issue

Fixes #944

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@catsby catsby requested a review from a team as a code owner October 28, 2024 20:44
@catsby catsby mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure chains in authservice don't get reordered and cause checksum changes
1 participant
@catsby