chore: simplify promtail values for scrape configs#94
Merged
jeff-mccoy merged 2 commits intomainfrom Jan 10, 2024
Merged
Conversation
mikevanhemert
approved these changes
Jan 10, 2024
Contributor
mikevanhemert
left a comment
mikevanhemert
left a comment
There was a problem hiding this comment.
Marie Kondo approved simplification
mikevanhemert
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.3](v0.7.2...v0.7.3) (2024-01-11) ### Bug Fixes * add test for disallow selinux options and handle checking for us… ([#96](#96)) ([88b969e](88b969e)) ### Miscellaneous * **deps:** update uds to v0.5.3, zarf to v0.32.1, and uds-k3d to 0.3.0 ([#77](#77)) ([596f9d8](596f9d8)) * open the aperture for pr workflow triggering ([#90](#90)) ([d8a72f2](d8a72f2)) * simplify promtail values for scrape configs ([#94](#94)) ([6c2513b](6c2513b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
mjnagel
added a commit
to BagelLab/uds-core
that referenced
this pull request
Nov 14, 2025
🤖 I have created a release *beep* *boop* --- ## [0.7.3](defenseunicorns/uds-core@v0.7.2...v0.7.3) (2024-01-11) ### Bug Fixes * add test for disallow selinux options and handle checking for us… ([#96](defenseunicorns#96)) ([88b969e](defenseunicorns@88b969e)) ### Miscellaneous * **deps:** update uds to v0.5.3, zarf to v0.32.1, and uds-k3d to 0.3.0 ([#77](defenseunicorns#77)) ([596f9d8](defenseunicorns@596f9d8)) * open the aperture for pr workflow triggering ([#90](defenseunicorns#90)) ([d8a72f2](defenseunicorns@d8a72f2)) * simplify promtail values for scrape configs ([#94](defenseunicorns#94)) ([6c2513b](defenseunicorns@6c2513b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After reviewing upstream defaults the only additional piece we should need is the node specific scrape config to ensure node logs are available. If needed we can add/modify more labels/scrape configs based on any dashboards/other things we start using with Loki. For now this is sufficient for the explore tab to view logs by app/ns/etc and view node logs.
Related Issue
Fixes #38
Type of change
Checklist before merging