Skip to content

fix: remove loki gateway anti-affinity#111

Merged
mjnagel merged 2 commits intomainfrom
loki-gateway-affinity
Jan 18, 2024
Merged

fix: remove loki gateway anti-affinity#111
mjnagel merged 2 commits intomainfrom
loki-gateway-affinity

Conversation

@mjnagel
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel commented Jan 18, 2024

Description

It was discovered in test that the anti-affinity set on the gateway is problematic during upgrades. This is partially because we are on a single node for k3d, but in general the anti-affinity does not make sense to have here since the gateway is a single replica setup.

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@mjnagel mjnagel self-assigned this Jan 18, 2024
Copy link
Copy Markdown
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjnagel mjnagel closed this Jan 18, 2024
@mjnagel
Copy link
Copy Markdown
Contributor Author

mjnagel commented Jan 18, 2024

Closing - this doesn't seem viable to work across the upgrade on a single node cluster.

@mjnagel mjnagel deleted the loki-gateway-affinity branch January 18, 2024 17:25
@mjnagel mjnagel restored the loki-gateway-affinity branch January 18, 2024 17:47
@mjnagel mjnagel reopened this Jan 18, 2024
Copy link
Copy Markdown
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the upgrade passes this time LGTM

@mjnagel mjnagel merged commit 2cba42e into main Jan 18, 2024
@mjnagel mjnagel deleted the loki-gateway-affinity branch January 18, 2024 18:05
zachariahmiller pushed a commit that referenced this pull request Jan 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.8.1](v0.8.0...v0.8.1)
(2024-01-18)


### Bug Fixes

* remove loki gateway anti-affinity
([#111](#111))
([2cba42e](2cba42e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
mjnagel added a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.8.1](defenseunicorns/uds-core@v0.8.0...v0.8.1)
(2024-01-18)


### Bug Fixes

* remove loki gateway anti-affinity
([#111](defenseunicorns#111))
([2cba42e](defenseunicorns@2cba42e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants