Skip to content

feat: keycloak helper tasks#462

Merged
mjnagel merged 12 commits intomainfrom
373-remove-test-realm
Apr 14, 2025
Merged

feat: keycloak helper tasks#462
mjnagel merged 12 commits intomainfrom
373-remove-test-realm

Conversation

@slaskawi
Copy link
Copy Markdown
Contributor

@slaskawi slaskawi commented Apr 9, 2025 •
edited
Loading

Description

This Pull Request introduces a few helper tasks for managing Keycloak

Related Issue

Relates to: defenseunicorns/uds-identity-config#373

Checklist before merging

  • ADR proposed if making an architectural change to the repo
  • Tests run, docs added or updated as needed

@slaskawi slaskawi force-pushed the 373-remove-test-realm branch from d5b2a48 to d8f7012 Compare April 9, 2025 09:54
@slaskawi slaskawi marked this pull request as ready for review April 9, 2025 09:59
@slaskawi slaskawi requested review from a team as code owners April 9, 2025 09:59
@slaskawi slaskawi requested review from a team April 9, 2025 09:59
@slaskawi slaskawi mentioned this pull request Apr 9, 2025
Merged
5 tasks
@slaskawi slaskawi closed this Apr 9, 2025
@slaskawi slaskawi reopened this Apr 9, 2025
zachariahmiller
zachariahmiller requested changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general i think this looks fine. Requested a couple of changes and asked a couple of questions. Inclined to approve this if the answers are "yes" and if you can make the very minor changes i suggested.

Comment thread tasks/setup.yaml
Comment thread tasks/setup.yaml Outdated
Comment thread tasks/setup.yaml Outdated
Comment thread tasks/setup.yaml Outdated
Comment thread tasks/setup.yaml Outdated
Comment thread tasks/setup.yaml Outdated
Comment thread tasks/setup.yaml Outdated
slaskawi and others added 6 commits April 9, 2025 18:48
@slaskawi @zachariahmiller
Update tasks/setup.yaml
eef62eb 
Co-authored-by: zamaz <71521611+zachariahmiller@users.noreply.github.com>
@slaskawi @zachariahmiller
Update tasks/setup.yaml
91f81c2 
Co-authored-by: zamaz <71521611+zachariahmiller@users.noreply.github.com>
@slaskawi @zachariahmiller
Update tasks/setup.yaml
9784909 
Co-authored-by: zamaz <71521611+zachariahmiller@users.noreply.github.com>
@slaskawi @zachariahmiller
Update tasks/setup.yaml
bd8d312 
Co-authored-by: zamaz <71521611+zachariahmiller@users.noreply.github.com>
@slaskawi @zachariahmiller
Update tasks/setup.yaml
4577fac 
Co-authored-by: zamaz <71521611+zachariahmiller@users.noreply.github.com>
@slaskawi
Reverted sleep to 5
667b574
zachariahmiller
zachariahmiller previously approved these changes Apr 9, 2025
View reviewed changes
@slaskawi
Copy link
Copy Markdown
Contributor Author

slaskawi commented Apr 9, 2025

Thanks for the review @zachariahmiller !

I'll probably test it a bit more in UDS Core before the merge. I want to be 100% sure I won't break anything and we're safe to move Keycloak things here.

@slaskawi slaskawi mentioned this pull request Apr 10, 2025
Merged
5 tasks
chance-coleman
chance-coleman previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@chance-coleman chance-coleman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't feel strongly about this, but does feel weird to introduce a new task rather than just update the existing create-doug-user functionality.

mjnagel
mjnagel reviewed Apr 10, 2025
View reviewed changes
Comment thread tasks/setup.yaml Outdated
mjnagel
mjnagel reviewed Apr 10, 2025
View reviewed changes
Comment thread tasks/setup.yaml Outdated
@slaskawi
Copy link
Copy Markdown
Contributor Author

slaskawi commented Apr 11, 2025

LGTM. I don't feel strongly about this, but does feel weird to introduce a new task rather than just update the existing create-doug-user functionality.

@UnicornChance The primary reason I deprecated it is that the task name falls out of the naming convention. All Keycloak related tasks start with keycloak and this one didn't and it was harder to find in my opinion.

I left it there just in case someone uses it. I'll probably remove it in a bit.

@slaskawi slaskawi dismissed stale reviews from chance-coleman and zachariahmiller via 48a515a April 11, 2025 06:45
@mjnagel mjnagel merged commit dee8b17 into main Apr 14, 2025
22 checks passed
@mjnagel mjnagel deleted the 373-remove-test-realm branch April 14, 2025 16:09
@github-actions github-actions Bot mentioned this pull request Apr 14, 2025
Merged
chance-coleman added a commit to defenseunicorns/uds-core that referenced this pull request Apr 14, 2025
@slaskawi @chance-coleman
feat: task cleanup for Keycloak (#1448)
5af6f2b 
## Description

This Pull Request cleans up tasks related to Keycloak as they were moved
to UDS Common repo.

This Pull Request depends on
defenseunicorns/uds-common#462. I will mark it
as ready for review once the UDS Common PR gets merged and I can switch
to `main` branch here.

## Related Issue

Relates to:
defenseunicorns/uds-identity-config#373

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

N/A

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: UnicornChance <chance@defenseunicorns.com>
Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
noahpb pushed a commit to defenseunicorns/uds-core that referenced this pull request Apr 15, 2025
@slaskawi @chance-coleman @noahpb
feat: task cleanup for Keycloak (#1448)
60abb4a 
## Description

This Pull Request cleans up tasks related to Keycloak as they were moved
to UDS Common repo.

This Pull Request depends on
defenseunicorns/uds-common#462. I will mark it
as ready for review once the UDS Common PR gets merged and I can switch
to `main` branch here.

## Related Issue

Relates to:
defenseunicorns/uds-identity-config#373

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

N/A

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: UnicornChance <chance@defenseunicorns.com>
Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
noahpb pushed a commit to defenseunicorns/uds-core that referenced this pull request Apr 17, 2025
@slaskawi @chance-coleman @noahpb
feat: task cleanup for Keycloak (#1448)
6de6c90 
## Description

This Pull Request cleans up tasks related to Keycloak as they were moved
to UDS Common repo.

This Pull Request depends on
defenseunicorns/uds-common#462. I will mark it
as ready for review once the UDS Common PR gets merged and I can switch
to `main` branch here.

## Related Issue

Relates to:
defenseunicorns/uds-identity-config#373

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

N/A

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: UnicornChance <chance@defenseunicorns.com>
Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@slaskawi @chance-coleman @mjnagel
feat: task cleanup for Keycloak (defenseunicorns#1448)
5a39a9f 
## Description

This Pull Request cleans up tasks related to Keycloak as they were moved
to UDS Common repo.

This Pull Request depends on
defenseunicorns/uds-common#462. I will mark it
as ready for review once the UDS Common PR gets merged and I can switch
to `main` branch here.

## Related Issue

Relates to:
defenseunicorns/uds-identity-config#373

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

N/A

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: UnicornChance <chance@defenseunicorns.com>
Co-authored-by: Chance <139784371+UnicornChance@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachariahmiller zachariahmiller zachariahmiller left review comments

@mjnagel mjnagel mjnagel approved these changes

@chance-coleman chance-coleman chance-coleman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slaskawi @mjnagel @zachariahmiller @chance-coleman