Merged
Conversation
Racer159
reviewed
Jan 8, 2024
| return err | ||
| } | ||
| path := filepath.Join(dst, config.BundleSBOM, f.NameInArchive) | ||
| // todo: handle collisions? especially for zarf-component SBOM files? |
Contributor
There was a problem hiding this comment.
if you more simply wrap the tarballs from each package that will naturally separate them and may simplify the logic for matching OCI descriptors and extracting things from them.
Also note how zarf package inspect <package> --sbom-out directory works (it makes sub dirs for the package by name).
Contributor
There was a problem hiding this comment.
This logic also clobbers the compare.html which will cause weirdness in the SBOM selector when going to the compare screen.
Contributor
There was a problem hiding this comment.
(it may be good to have a tech debt issue / discussion on how the Zarf team can help - it may be good for y'all to make your own high level compare file and such too).
Contributor
Author
decleaver
requested review from
UncleGedd,
jeff-mccoy and
mikevanhemert
as code owners
1 task
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Jan 11, 2024
…3.0 (#77) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli) | patch | `0.5.2` -> `0.5.3` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.5.3`](https://github.com/defenseunicorns/uds-cli/releases/tag/v0.5.3) [Compare Source](https://github.com/defenseunicorns/uds-cli/compare/v0.5.2...v0.5.3) ##### What's Changed - chore(deps): update anchore/sbom-action action to v0.15.2 by [@​renovate](https://github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/297](https://github.com/defenseunicorns/uds-cli/pull/297) - chore(deps): update github/codeql-action action to v3.22.12 by [@​renovate](https://github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/294](https://github.com/defenseunicorns/uds-cli/pull/294) - chore(deps): update actions/download-artifact action to v4.1.0 by [@​renovate](https://github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/291](https://github.com/defenseunicorns/uds-cli/pull/291) - chore: update to zarf version 0.32.1 by [@​decleaver](https://github.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/300](https://github.com/defenseunicorns/uds-cli/pull/300) **Full Changelog**: defenseunicorns/uds-cli@v0.5.2...v0.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jeff McCoy <code@jeffm.us> Co-authored-by: Megamind <882485+jeff-mccoy@users.noreply.github.com> Co-authored-by: razzle <harry@razzle.cloud> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update uds-cli zarf version to v0.32.1 and supports zarf multi arch
Related Issue
Relates to #296
Type of change
Checklist before merging