-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npx [email protected] crd
command outputs .ts files that must be edited before use
#374
Comments
In my case I'm also seeing some weirdness around Example to reproduce: npx kubernetes-fluent-client crd https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.76.1/example/prometheus-operator-crd/monitoring.coreos.com_podmonitors.yaml <some file path to put CRD type> |
Found a link to the "fix" I was using during Dash Days PolicyReport excellent example. This was built into the dev CLI (as a hack) but could probably be used as a starting point for polishing / moving into Pepr. |
## Description The kfc crd command generates files that need to be manually edited. This is annoying. Need to fix so that generated files do not need manual editing. ... ## Related Issue Fixes #374 <!-- or --> Relates to # ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
🎉 This issue has been resolved in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Environment
Device and OS: Ubuntu 24.04
App version: v3.0.2
Kubernetes distro being used: n/a
Definition of Done
Potential look at the e2e test around PolicyReports
Steps to reproduce
Expected result
An error-free .ts file should be generated.
Actual Result
The requested .ts file is generated but it has TS errors.
Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Annoying
Additional Context
Problem can be worked around by manually editing the generated files, but... that's annoying to have to do.
The text was updated successfully, but these errors were encountered: