Skip to content

Bug fix: Remove client optimizer param_group list item that does not have 'params' #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffra merged 5 commits into from
Mar 12, 2021
Merged

Bug fix: Remove client optimizer param_group list item that does not have 'params' #827

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f90b4b7
Remove param_group that does not have 'params' in the client optimize…
cli99 Mar 6, 2021
9053c9e
fix typo
cli99 Mar 6, 2021
8f7469e
fix printing
cli99 Mar 6, 2021
7b64a96
fix bug
cli99 Mar 7, 2021
0ae2a71
Merge branch 'master' into cheng/hf
jeffra Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,12 @@ def _configure_distributed_model(self, model):
def _configure_optimizer(self, client_optimizer, model_parameters):

if client_optimizer is not None:
client_optimizer.param_groups[:] = [
pg for pg in client_optimizer.param_groups if len(pg["params"]) != 0
]
logger.info(
"Removing param_group that has no 'params'in the client Optimizer")

basic_optimizer = client_optimizer
if self.global_rank == 0:
logger.info('Using client Optimizer as basic optimizer')
Expand Down