Skip to content

Conversation

@stas00
Copy link
Collaborator

@stas00 stas00 commented Feb 20, 2021

Invalid param name

Thanks.

Invalid param name

Thanks.
Copy link
Collaborator

@jeffra jeffra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@jeffra jeffra merged commit e60e92e into deepspeedai:master Feb 20, 2021
@stas00 stas00 deleted the patch-1 branch February 20, 2021 21:23
@stas00
Copy link
Collaborator Author

stas00 commented Feb 20, 2021

Is there are reason why you use this weird markdown:

***loss\_scale\_window***

and not just:

**loss_scale_window**

I'm not sure why you had to do that in first place, but it also prevents grep from working and finding such bugs as fixes in this PR.

edit or I see - it's for bold+italics - let's see if there is a better way

Looks like github fixed their parser to do the right thing with ***A_B***. test: A_B

But if your doc builder doesn't - this is probably a more sustainable approach: <i>**A_B**</i> test: A_B

@stas00
Copy link
Collaborator Author

stas00 commented Feb 20, 2021

Here is a little perl magic to quickly rewrite your docs, e.g. on:

perl -pi -e 'BEGIN{ sub a{$_=$_[0]; ~s|\\||g; $_}} s|\*\*\*(\S+)\*\*\*|"<i>**".a($1)."**</i>"|msge' docs/_pages/config-json.md

To change all .mds:

find . -name "*md" -exec perl -pi -e 'BEGIN{ sub a{$_=$_[0]; ~s|\\||g; $_}} s|\*\*\*(\S+)\*\*\*|"<i>**".a($1)."**</i>"|msge' {} \;

it seems to change just 2 files.

Proposal: #775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants