Skip to content

[WarmupDecayLR] fix log(0) & 1/log(1) bugs #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cli99 merged 5 commits into from
Mar 12, 2021
Merged

[WarmupDecayLR] fix log(0) & 1/log(1) bugs #772

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b93a38
fix log(0) & 1/log(1) bugs
stas00 Feb 20, 2021
2eab8eb
simplify
stas00 Feb 20, 2021
cfafbca
Merge branch 'master' into div-by-zero
jeffra Feb 25, 2021
a019da8
Merge branch 'master' into div-by-zero
RezaYazdaniAminabadi Feb 26, 2021
d6b2af6
Merge branch 'master' into div-by-zero
cli99 Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deepspeed/runtime/lr_schedules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,8 +706,8 @@ def __init__(self,
self.min_lrs = self._format_param(self.optimizer, warmup_min_lr, "min_lr")
self.max_lrs = self._format_param(self.optimizer, warmup_max_lr, "max_lr")
self.delta_lrs = [big - small for big, small in zip(self.max_lrs, self.min_lrs)]
self.warmup_num_steps = warmup_num_steps
self.inverse_log_warm_up = 1.0 / math.log(warmup_num_steps)
self.warmup_num_steps = max(2, warmup_num_steps)
self.inverse_log_warm_up = 1.0 / math.log(self.warmup_num_steps)
self.last_batch_iteration = last_batch_iteration

def get_lr(self):
Expand Down