Skip to content

Modal CI #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loadams merged 108 commits into from
Aug 11, 2025
Merged

Modal CI #7289

loadams merged 108 commits into from
Aug 11, 2025

Conversation

@sfc-gh-truwase
Copy link
Collaborator

@sfc-gh-truwase sfc-gh-truwase commented May 16, 2025 •
edited
Loading

This is an initial effort to migrate CI unto Modal infra. This PR creates two new workflows that run on Modal

  1. modal-torch-latest: a subset of nv-torch-latest-v100 that includes tests/unit/runtime/zero/test_zero.py.
  2. modal-accelerate: a full copy of nv-accelerate-v100.

Follow up PRs will selectively migrate relevant workflows onto Modal.

@sfc-gh-truwase
Modal CI
0417dbe 
Signed-off-by: Olatunji Ruwase <[email protected]>
sfc-gh-truwase and others added 27 commits May 16, 2025 21:41
@sfc-gh-truwase
Modal CI
8b49d0d 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Modal CI
68a44dd 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
uv for ds install
35547e9 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
uv for ds install
0c267e4 
Signed-off-by: Olatunji Ruwase <[email protected]>
@stas00
Update torch_latest_ci.py
ca48e9d
@sfc-gh-truwase
uv for ds install
8f63a4c 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Merge branch 'tjruwase/modal_ci' of https://github.com/deepspeedai/De…
b7e51d8 
…epSpeed into tjruwase/modal_ci
@sfc-gh-truwase
Modal testing
dba33e9 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Modal testing
f688973 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Handle folders and symlinks
5a6d2c8 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Testing
985c5f3 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Testing
37a7ed1 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Use torch<2.7.0
c0c406b 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Full torch latest UT
8c76099 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Fewer UTs
665770d 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
nvme UTs
60c0e82 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
zero UTs
79a7a27 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Merge branch 'master' into tjruwase/modal_ci
8839780
@sfc-gh-truwase
Avoid 30min timeout
986008a 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Merge branch 'master' into tjruwase/modal_ci
4e85caf
@loadams
Update to latest checkout action
6dce798
@loadams
Merge branch 'master' into tjruwase/modal_ci
b3f661e
@sfc-gh-truwase
Avoid 30min timeout
d3c7c80 
Signed-off-by: Olatunji Ruwase <[email protected]>
@loadams
Merge branch 'master' into tjruwase/modal_ci
6925ed2
@sfc-gh-truwase
Merge branch 'master' into tjruwase/modal_ci
9756a38
@tjruwase
Fix torch version
fedfc31 
Signed-off-by: Olatunji Ruwase <[email protected]>
@tjruwase
Restructure
77d069a 
Signed-off-by: Olatunji Ruwase <[email protected]>
sfc-gh-truwase and others added 20 commits August 9, 2025 15:14
@sfc-gh-truwase
Check DS package
360664e 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Check DS package
a36e3fa 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Check DS package
7372b71 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Check DS package
ba462d4 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Check DS package
c12fe92 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Fix PYTHONPATH
4b96926 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Fix PYTHONPATH
6bf4d18 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Debug PYTHONPATH
a4927c7 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Debug PYTHONPATH
56c0aaf 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Debug PYTHONPATH
134fb7d 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Debug PYTHONPATH
b180173 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Debug DS build
63da02c 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Fix DS install
1bee006 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Fix DS path
a0b84a1 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Cleanup
c2c6e58 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Merge branch 'master' into tjruwase/modal_ci
7c9462a
@sfc-gh-truwase
Format
034e61a 
Signed-off-by: Olatunji Ruwase <[email protected]>
@sfc-gh-truwase
Merge branch 'tjruwase/modal_ci' of https://github.com/deepspeedai/De…
8a72a98 
…epSpeed into tjruwase/modal_ci
@loadams
Merge branch 'master' into tjruwase/modal_ci
4b2959d
@loadams
Merge branch 'master' into tjruwase/modal_ci
936bbc8
loadams
loadams approved these changes Aug 11, 2025
View reviewed changes
@loadams loadams enabled auto-merge (squash) August 11, 2025 20:11
@loadams loadams merged commit a12de38 into master Aug 11, 2025
12 checks passed
@loadams loadams deleted the tjruwase/modal_ci branch August 11, 2025 20:13
@Antlera Antlera mentioned this pull request Aug 12, 2025
Merged
LYMDLUT pushed a commit to LYMDLUT/DeepSpeed that referenced this pull request Aug 20, 2025
@sfc-gh-truwase @stas00
@loadams @tjruwase @sfc-gh-sbekman @LYM-fire
Modal CI (deepspeedai#7289)
61681ce 
This is an initial effort to migrate CI unto Modal infra. This PR
creates two new workflows that run on Modal
1. modal-torch-latest: a subset of nv-torch-latest-v100 that includes
`tests/unit/runtime/zero/test_zero.py`.
2. modal-accelerate: a full copy of nv-accelerate-v100.

Follow up PRs will selectively migrate relevant workflows onto Modal.

---------

Signed-off-by: Olatunji Ruwase <[email protected]>
Signed-off-by: Olatunji Ruwase <[email protected]>
Signed-off-by: Tunji Ruwase <[email protected]>
Co-authored-by: Stas Bekman <[email protected]>
Co-authored-by: Logan Adams <[email protected]>
Co-authored-by: Logan Adams <[email protected]>
Co-authored-by: Olatunji Ruwase <[email protected]>
Co-authored-by: Stas Bekman <[email protected]>
Signed-off-by: lym <[email protected]>
mauryaavinash95 pushed a commit to DataStates/DeepSpeed that referenced this pull request Oct 4, 2025
@sfc-gh-truwase @stas00
@loadams @tjruwase @sfc-gh-sbekman
Modal CI (deepspeedai#7289)
b5f8596 
This is an initial effort to migrate CI unto Modal infra. This PR
creates two new workflows that run on Modal
1. modal-torch-latest: a subset of nv-torch-latest-v100 that includes
`tests/unit/runtime/zero/test_zero.py`.
2. modal-accelerate: a full copy of nv-accelerate-v100. 

Follow up PRs will selectively migrate relevant workflows onto Modal.

---------

Signed-off-by: Olatunji Ruwase <[email protected]>
Signed-off-by: Olatunji Ruwase <[email protected]>
Signed-off-by: Tunji Ruwase <[email protected]>
Co-authored-by: Stas Bekman <[email protected]>
Co-authored-by: Logan Adams <[email protected]>
Co-authored-by: Logan Adams <[email protected]>
Co-authored-by: Olatunji Ruwase <[email protected]>
Co-authored-by: Stas Bekman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loadams loadams loadams approved these changes

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

@tohtana tohtana Awaiting requested review from tohtana tohtana is a code owner

@stas00 stas00 Awaiting requested review from stas00

@hwchen2017 hwchen2017 Awaiting requested review from hwchen2017

+1 more reviewer

@sfc-gh-sbekman sfc-gh-sbekman sfc-gh-sbekman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sfc-gh-truwase @loadams @sfc-gh-sbekman @stas00 @tjruwase