implement missing get_last_lr #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
Collaborator
Author
|
It looks like your CI is stuck - not doing the build since 12 hours... |
Collaborator
Super strange, not sure what the issue was. Our CI nodes were idle but the job didn't submit to our queue for some reason. After updating your branch with master it seems to have forced it to kick off though. |
tjruwase
reviewed
Dec 11, 2020
tjruwase
approved these changes
Dec 11, 2020
tjruwase
approved these changes
Dec 11, 2020
stas00
commented
Dec 12, 2020
tjruwase
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
by adding
get_last_lras it is implemented in pytorchI think it was added around pytorch-1.4.
I added
get_last_lrto the rest of lr classes in that file, not sure if there are others.