Skip to content

Conversation

@RezaYazdaniAminabadi
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jeffra jeffra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as convergence checks are fine.

@RezaYazdaniAminabadi
Copy link
Contributor Author

RezaYazdaniAminabadi commented Dec 11, 2020

Thanks Jeff, I think the part I changed would not impact the convergence a lot. Just that it covers more cases for the Transformer Kernel. By the way, there is one change I did for the transformer API (https://github.com/microsoft/DeepSpeed/pull/587/files#diff-05e444aa64c2739a8357e712df27aaf32a95c7b54479994d9741008dd226d793L21), so it won't need to get the sequence length, I can use the same strategy to remove batch_size from config too. These last two changes will potentially help smooth our op-injection line of work!

@RezaYazdaniAminabadi
Copy link
Contributor Author

I also need to make a PR for the DeepSpeed-Example branch to consolidate these change and won't let our bing-bert example crash!

@jeffra
Copy link
Collaborator

jeffra commented Dec 11, 2020

I also need to make a PR for the DeepSpeed-Example branch to consolidate these change and won't let our bing-bert example crash!

Sounds good. Once we have an update DSE let's update the submodule here and we can merge this.

@jeffra jeffra merged commit fd2f970 into master Dec 17, 2020
@zmxdream
Copy link
Contributor

zmxdream commented Feb 24, 2021

Hi, I took a look at softmax_ kernel.cu, Is the code customized for the sequence length of power 2, such as 128, 256, 512? Doesn't it seem to apply to a sequence length of 50? right?

I also need to make a PR for the DeepSpeed-Example branch to consolidate these change and won't let our bing-bert example crash!

@mrwyattii mrwyattii deleted the transformer/support-arbitrary-seqlen branch July 7, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants