Fix Hybrid Engine metrics printing #4789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
approved these changes
Dec 8, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
The metrics print statement in the Hybrid Engine had a bug where `self._total_batch_size` was assumed to exist even when this variable was not initialized due to no corresponding inference policy. This PR fixes this by performing a check when constructing the metrics print. Addresses: deepspeedai/DeepSpeedExamples#593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics print statement in the Hybrid Engine had a bug where
self._total_batch_sizewas assumed to exist even when this variable was not initialized due to no corresponding inference policy.This PR fixes this by performing a check when constructing the metrics print.
Addresses: deepspeedai/DeepSpeedExamples#593