Skip to content

Conversation

@caropen
Copy link

@caropen caropen commented Jul 13, 2023

[Deleted]
So sorry, I wanted to work on a fork and clicked wrong! Thanks for pointing it out!

Pydantic package moved to version 2.0, "While we'll do our best to avoid breaking changes, some things will break.". When runnning a training in a newly set-up environment with 2.0 version one gets an error: me/config_utils.py", line 82, in _deprecated_fields_check
      if field.field_info.extra.get("deprecated", False):
  AttributeError: 'FieldInfo' object has no attribute 'field_info'
@caropen caropen requested review from jeffra and mrwyattii as code owners July 13, 2023 15:22
psutil
py-cpuinfo
pydantic
pydantic==1.9.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's going on with the diff here, but in the master branch I see this as already being pydantic<2.0.0?

https://github.com/microsoft/DeepSpeed/blob/master/requirements/requirements.txt#L7

Was that not working for you?

@mrwyattii
Copy link
Contributor

We have pydantic pinned to <2.0.0 already: https://github.com/microsoft/DeepSpeed/blob/master/requirements/requirements.txt#L7

Please update your fork if you do not see this change there.

We will be upgrading for pydantic 2.0 support soon: #3902

@mrwyattii mrwyattii closed this Jul 13, 2023
@caropen caropen changed the title specified pydantic version 1.9.1 [deleted] Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants