Skip to content

fix check params #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
satpalsr wants to merge 10 commits into from
Closed

fix check params #3036

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a00619
fix check params
satpalsr Mar 16, 2023
ec6736d
Merge branch 'master' into satpalsr-patch
jeffra Mar 17, 2023
84e17e1
Merge branch 'master' into satpalsr-patch
jeffra Mar 21, 2023
6734a7a
Merge branch 'master' into satpalsr-patch
tjruwase Mar 24, 2023
adf6f6c
Merge branch 'master' into satpalsr-patch
tjruwase Mar 31, 2023
f038698
Merge branch 'master' into satpalsr-patch
tjruwase Apr 4, 2023
7ffac31
Merge branch 'master' into satpalsr-patch
tjruwase Apr 7, 2023
3036485
Merge branch 'master' into satpalsr-patch
lekurile Sep 1, 2023
256bad2
Merge branch 'master' into satpalsr-patch
lekurile Sep 1, 2023
6c09a75
Merge branch 'master' into satpalsr-patch
loadams Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,6 @@ def is_replicated(p):

@staticmethod
def __check_params(model: Module, dtype: torch.dtype) -> None:
return
if not all(param.dtype == dtype for param in model.parameters()) and dist.get_rank() == 0:
raise ValueError(f"{dtype} is enabled but the following parameters have dtype that is "
f"not {dtype}: "
Expand Down