Skip to content

Fix for Zero3 when MP>1 #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffra merged 3 commits into from
Sep 7, 2022
Merged

Fix for Zero3 when MP>1 #2289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2bea22
Fix for Zero3 when MP>1 and at least one batch param undefined
Sep 2, 2022
599535d
Merge branch 'master' into zero3-mp-fix
Quentin-Anthony Sep 6, 2022
d5ec6bd
Merge branch 'master' into zero3-mp-fix
jeffra Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deepspeed/runtime/zero/stage3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ def __init__(self,
max_live_parameters=max_live_parameters,
param_persistence_threshold=param_persistence_threshold,
model_persistence_threshold=model_persistence_threshold,
offload_param_config=offload_optimizer_config)
offload_param_config=offload_optimizer_config,
mpu=mpu)

self.persistent_parameters = self.parameter_offload.persistent_parameters
self._configure_offloading(offload_optimizer_config, offload_param_config)
Expand Down